Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify expired mission handling #133

Open
MikeJeffers opened this issue Mar 1, 2020 · 0 comments
Open

Robustify expired mission handling #133

MikeJeffers opened this issue Mar 1, 2020 · 0 comments
Labels
bug

Comments

@MikeJeffers
Copy link

@MikeJeffers MikeJeffers commented Mar 1, 2020

Make mission expiration logic more robust.
Server can get into a state where expired missions will continuously throw this:

[13:01:35] INF mission expired: guid:5e2d9c29-19e3-485d-b8ae-5bb62d192bca characterID:353 missionID:1169 expire:2/27/2020 12:27:43 PM current targetOrder:0 title:missiontemplate_random_geoscanning_01
[13:01:35] INF mission expired. guid:5e2d9c29-19e3-485d-b8ae-5bb62d192bca characterID:353 missionID:1169 expire:2/27/2020 12:27:43 PM current targetOrder:0 title:missiontemplate_random_geoscanning_01
[13:01:35] INF sending mission update to zone:5 isFinished:True
[13:01:35] ERR 
Exception Found:
Type: System.NullReferenceException
Message: Object reference not set to an instance of an object.
Source: Perpetuum
Stacktrace:    at Perpetuum.Services.MissionEngine.Missions.MissionStandingChangeCalculator.VisitRandomMission(RandomMission randomMission)
   at Perpetuum.Services.MissionEngine.Missions.MissionInProgress.WriteFailure()
   at Perpetuum.Services.MissionEngine.Missions.MissionInProgress.OnMissionFailure(Command command, MissionProcessor missionProcessor, ErrorCodes errorToInfo)
   at Perpetuum.Services.MissionEngine.AdministratorObjects.MissionAdministrator.MissionExpireCycle()
@MikeJeffers MikeJeffers added the bug label Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.