Fix force-landed transports taking off after (un)loading passengers.

OpenRA · Jul 1, 2019 · 5d8b6d6 · 5d8b6d6
1 parent da0b24e
commit 5d8b6d6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/OpenRA.Mods.Common/Activities/UnloadCargo.cs b/OpenRA.Mods.Common/Activities/UnloadCargo.cs
@@ -29,6 +29,7 @@ public class UnloadCargo : Activity
 		readonly WDist unloadRange;
 
 		Target destination;
+		bool takeOffAfterUnload;
 
 		public UnloadCargo(Actor self, WDist unloadRange, bool unloadAll = true)
 			: this(self, Target.Invalid, unloadRange, unloadAll)
@@ -74,7 +75,11 @@ protected override void OnFirstRun(Actor self)
 
 			// Move to the target destination
 			if (aircraft != null)
+			{
+				// Queue the activity even if already landed in case self.Location != destination
 				QueueChild(self, new Land(self, destination, unloadRange));
+				takeOffAfterUnload = !aircraft.AtLandAltitude;
+			}
 			else
 			{
 				var cell = self.World.Map.Clamp(this.self.World.Map.CellContaining(destination.CenterPosition));
@@ -135,7 +140,7 @@ public override Activity Tick(Actor self)
 				if (cargo.Info.AfterUnloadDelay > 0)
 					QueueChild(self, new Wait(cargo.Info.AfterUnloadDelay, false), true);
 
-				if (aircraft != null && !aircraft.Info.LandWhenIdle)
+				if (takeOffAfterUnload)
 					QueueChild(self, new TakeOff(self), true);
 			}
 

diff --git a/OpenRA.Mods.Common/Traits/Cargo.cs b/OpenRA.Mods.Common/Traits/Cargo.cs
@@ -105,6 +105,7 @@ public class Cargo : IPips, IIssueOrder, IResolveOrder, IOrderVoice, INotifyCrea
 		ConditionManager conditionManager;
 		int loadingToken = ConditionManager.InvalidConditionToken;
 		Stack<int> loadedTokens = new Stack<int>();
+		bool takeOffAfterLoad;
 
 		CPos currentCell;
 		public IEnumerable<CPos> CurrentAdjacentCells { get; private set; }
@@ -280,7 +281,10 @@ bool LockForPickup(Actor self)
 
 			var air = self.TraitOrDefault<Aircraft>();
 			if (air != null && !air.AtLandAltitude)
+			{
+				takeOffAfterLoad = true;
 				self.QueueActivity(new Land(self));
+			}
 
 			self.QueueActivity(new WaitFor(() => state != State.Locked, false));
 			return true;
@@ -294,9 +298,10 @@ void ReleaseLock(Actor self)
 			state = State.Free;
 
 			self.QueueActivity(new Wait(Info.AfterLoadDelay, false));
-			var air = self.TraitOrDefault<Aircraft>();
-			if (air != null)
+			if (takeOffAfterLoad)
 				self.QueueActivity(new TakeOff(self));
+
+			takeOffAfterLoad = false;
 		}
 
 		public string CursorForOrder(Actor self, Order order)