HasAnyValidWeapons doesn't check if Armament is disabled by a condition

[MustaphaTR]

OpenRA/OpenRA.Mods.Common/Traits/Attack/AttackBase.cs

Lines 201 to 215 in 0a1083e

	public bool HasAnyValidWeapons(Target t, bool checkForCenterTargetingWeapons = false)
	{
	if (IsTraitDisabled)
	return false;
	if (Info.AttackRequiresEnteringCell && (positionable == null || !positionable.CanEnterCell(t.Actor.Location, null, false)))
	return false;
	// PERF: Avoid LINQ.
	foreach (var armament in Armaments)
	{
	var checkIsValid = checkForCenterTargetingWeapons ? armament.Weapon.TargetActorCenter : !armament.OutOfAmmo;
	if (checkIsValid && armament.Weapon.IsValidAgainst(t, self.World, self))
	return true;
	}

On the image, Overlord tanks that under Hunt() activity tries to attack the Comanches, even tho they don't have Overlord Gatling upgrade (so Gatling weapon is disabled)

[pchote]

You can work around this in your yaml, and still should even after #13856 to improve performance: use your upgrade condition to switch between AutoTargetPrioritys that do/don't target aircraft.

[MustaphaTR]

I already did that after noticing the bug, but it doesn't look like fixing it alone, this is something to do with Hunt() too, not just AutoTarget behaviour.

[GraionDilach]

That's probably due to #12856.