New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart button for multiplayer replays #14104

Open
dragunoff opened this Issue Oct 3, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@dragunoff
Contributor

dragunoff commented Oct 3, 2017

Right now (playtest-20170930) the restart button during a replay is only available for single player replays. I dug in the code a bit and found that there is a condition:

if (world.LobbyInfo.NonBotClients.Count() == 1)

That makes sense for live games but not in the context of replays.

Often times I find myself wanting to restart a replay (cause I missed something or just to see the match from a different perspective). And with the current setup I'd have to go through all the motions of the menu and finding the replay.

I can see a couple of tickets about desyncs when restarting replays (#12523 and #13312). Is there a reason for not enabling it for multiplayer replays?

@Mailaender Mailaender changed the title from Restart button for multiplayer relpays to Restart button for multiplayer replays Oct 5, 2017

@reaperrr reaperrr closed this in #15216 Jun 16, 2018

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Aug 12, 2018

Contributor

#15216 unfortunately isn't issue-free, and we don't have time to fix that before the next release so we've reverted it for now.
That means we have to re-open this for the time being.

Contributor

reaperrr commented Aug 12, 2018

#15216 unfortunately isn't issue-free, and we don't have time to fix that before the next release so we've reverted it for now.
That means we have to re-open this for the time being.

@reaperrr reaperrr reopened this Aug 12, 2018

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Aug 13, 2018

Member

Turns out that the sync issues predate the removal of the button: #12523

Member

pchote commented Aug 13, 2018

Turns out that the sync issues predate the removal of the button: #12523

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Aug 13, 2018

Member

#13312 suggests that pausing the replay before restarting it may be sufficient to fix the desyncs.

Member

pchote commented Aug 13, 2018

#13312 suggests that pausing the replay before restarting it may be sufficient to fix the desyncs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment