New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpawnActorPower causes probably unneccessary Lint warnings #14116

Open
CH4Code opened this Issue Oct 5, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@CH4Code
Contributor

CH4Code commented Oct 5, 2017

Hey,
When using SpawnActorPower the lint-check outputs weird warnings like this:
Those errors have started appearing with the latests series of playtests and ONLY appear like this on SpawnActorPower.

OpenRA.Utility(1,1): Warning: Custom sprite image of actor wall is null.
OpenRA.Utility(1,1): Warning: Custom sprite image of actor wall is null.
OpenRA.Utility(1,1): Warning: Custom sprite image of actor wall is null.
OpenRA.Utility(1,1): Warning: Custom sprite image of actor wall is null.
OpenRA.Utility(1,1): Warning: Custom sprite image of actor wall is null.
OpenRA.Utility(1,1): Warning: Custom sprite image of actor wall is null.
OpenRA.Utility(1,1): Warning: Custom sprite image of actor wall is null.

Comparison with other powers has lead me to a suspicion. Here are the warnings for a nuke power without the firing actor having an ActivationSequence defined: (by setting ActivationSequence=undefined )

OpenRA.Utility(1,1): Error: Sprite image wall from actor wall of faction Random does not define sequence undefined from field Sequence of OpenRA.Mods.Common.Traits.GrantExternalConditionPowerInfo
OpenRA.Utility(1,1): Error: Sprite image wall from actor wall of faction atreides does not define sequence undefined from field Sequence of OpenRA.Mods.Common.Traits.GrantExternalConditionPowerInfo
OpenRA.Utility(1,1): Error: Sprite image wall from actor wall of faction harkonnen does not define sequence undefined from field Sequence of OpenRA.Mods.Common.Traits.GrantExternalConditionPowerInfo
OpenRA.Utility(1,1): Error: Sprite image wall from actor wall of faction ordos does not define sequence undefined from field Sequence of OpenRA.Mods.Common.Traits.GrantExternalConditionPowerInfo
OpenRA.Utility(1,1): Error: Sprite image wall from actor wall of faction corrino does not define sequence undefined from field Sequence of OpenRA.Mods.Common.Traits.GrantExternalConditionPowerInfo
OpenRA.Utility(1,1): Error: Sprite image wall from actor wall of faction mercenary does not define sequence undefined from field Sequence of OpenRA.Mods.Common.Traits.GrantExternalConditionPowerInfo
OpenRA.Utility(1,1): Error: Sprite image wall from actor wall of faction smuggler does not define sequence undefined from field Sequence of OpenRA.Mods.Common.Traits.GrantExternalConditionPowerInfo
OpenRA.Utility(1,1): Error: Sprite image wall from actor wall of faction fremen does not define sequence undefined from field Sequence of OpenRA.Mods.Common.Traits.GrantExternalConditionPowerInfo

Note that both of the warnings have 8 lines. So I guess some Interface got modified in the latest round of playtests and now requires some kind of activation sequence on SpawnActorPower, which isn't really needed/defined in SpawnActorPowerInfo.

Here is a map showcasing the error.

Please fix, I make heavy use of SpawnActorPower and my maps don't get the lint-approved-quality seal because of this ;)

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Oct 5, 2017

Contributor

SpawnActorPower ignores placement rules, so I wonder if your power even works as intended... it's a piece of crap only useful to place cameras and nothing more.

The lint errors are caused by the null EffectImage with idle EffectSequence though within.

Contributor

GraionDilach commented Oct 5, 2017

SpawnActorPower ignores placement rules, so I wonder if your power even works as intended... it's a piece of crap only useful to place cameras and nothing more.

The lint errors are caused by the null EffectImage with idle EffectSequence though within.

@CH4Code

This comment has been minimized.

Show comment
Hide comment
@CH4Code

CH4Code Oct 5, 2017

Contributor

good enough to place temporary targeting dummies

Contributor

CH4Code commented Oct 5, 2017

good enough to place temporary targeting dummies

@abcdefg30 abcdefg30 added the Bug label Oct 5, 2017

@CH4Code

This comment has been minimized.

Show comment
Hide comment
@CH4Code

CH4Code Oct 13, 2017

Contributor

Thanks. Setting "EffectSequence: " (to null) removed all warnings.

Contributor

CH4Code commented Oct 13, 2017

Thanks. Setting "EffectSequence: " (to null) removed all warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment