New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectators show as "Ally" in team chat #14140

Closed
ghost opened this Issue Oct 7, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@ghost

ghost commented Oct 7, 2017

If a player in a lobby selects a team, and then subsequently switches to being a spectator, that spectator's chat messages will show as (Ally) to players with that same team value.

@dragunoff

This comment has been minimized.

Show comment
Hide comment
@dragunoff

dragunoff Oct 8, 2017

Contributor

That player also keeps his color in chat messages as opposed to having neutral white color (even if not on a team). To reproduce - join a MP game, click "Play in this slot" and then switch to "Spectate". IIRC this label change is only visible in game and not in replays.

Contributor

dragunoff commented Oct 8, 2017

That player also keeps his color in chat messages as opposed to having neutral white color (even if not on a team). To reproduce - join a MP game, click "Play in this slot" and then switch to "Spectate". IIRC this label change is only visible in game and not in replays.

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v Oct 18, 2017

Contributor

Seems already fixed in dev version?

image

Edit: I see now the issue - player1 (Spectator) (Ally) - I will look at it.

Contributor

rob-v commented Oct 18, 2017

Seems already fixed in dev version?

image

Edit: I see now the issue - player1 (Spectator) (Ally) - I will look at it.

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v Oct 18, 2017

Contributor

When player switches to Spectator and back - should player keep previous Team number like so far or better to always reset it to No team when switching to Spectator? (I can solve this issue by Team reset or ignoring Team number in chat). Let me know please.

Contributor

rob-v commented Oct 18, 2017

When player switches to Spectator and back - should player keep previous Team number like so far or better to always reset it to No team when switching to Spectator? (I can solve this issue by Team reset or ignoring Team number in chat). Let me know please.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Oct 18, 2017

Member

Clearing the team when becoming a spec seems like the most reasonable option to me (or, as discussed a few times before, adding team-restricted spectators)

Member

pchote commented Oct 18, 2017

Clearing the team when becoming a spec seems like the most reasonable option to me (or, as discussed a few times before, adding team-restricted spectators)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment