New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allies-03b & drop-zone-w weapon issues #14321

Closed
FrameLimiter opened this Issue Nov 8, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 8, 2017

Member

Why aren't our lint tests catching any of these issues?

Member

pchote commented Nov 8, 2017

Why aren't our lint tests catching any of these issues?

@abcdefg30 abcdefg30 added the Bug label Nov 8, 2017

@Arular101

This comment has been minimized.

Show comment
Hide comment
@Arular101

Arular101 Nov 13, 2017

Contributor

I removed the FireballLauncher: Projectile: High: True in Allies 03b in this PR #14326 . This is not needed anymore in that mission.

Contributor

Arular101 commented Nov 13, 2017

I removed the FireballLauncher: Projectile: High: True in Allies 03b in this PR #14326 . This is not needed anymore in that mission.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Nov 14, 2017

Contributor

Why aren't our lint tests catching any of these issues?

I think we don't throw any warnings/errors on non-existing traits/properties in general.

Contributor

reaperrr commented Nov 14, 2017

Why aren't our lint tests catching any of these issues?

I think we don't throw any warnings/errors on non-existing traits/properties in general.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 14, 2017

Member

We really should be throwing warnings for these...

Member

pchote commented Nov 14, 2017

We really should be throwing warnings for these...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment