New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize *Info.Type naming #14345

Open
pchote opened this Issue Nov 12, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@pchote
Member

pchote commented Nov 12, 2017

Logs (edited for clarity):

[12:57:20] | <penev> we have *Type(s) all over the place
[12:57:27] | <penev> not just Type(s)
[12:57:34] | <penev> and IMO it's better that way
[12:57:39] | <pchote> we had CaptureTypes on Capturable, and then Types on Captures and Type on TransformOnCapture
[12:58:31] | <penev> IMO they should all be CaptureTypes
[12:59:40] | <pchote> AcceptsDeliveredCashInfo.ValidTypes / DeliversCashInfo.Type
[13:00:07] | <pchote> we also have BridgeHutInfo.Types / GroundLevelBridgeInfo.Type
[13:01:05] | <penev> yes, and IMO we should gradually change all those to be more meaningful
[13:01:14] | <pchote> and PassengerInfo.CargoType / Cargo.Types
[13:01:31] | <pchote> what a mess

@abcdefg30 abcdefg30 added the Refactor label Nov 12, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 12, 2017

Member

TODO: Decide on a standard before filing a PR. There is still some controversy in how this should be done.

Member

pchote commented Nov 12, 2017

TODO: Decide on a standard before filing a PR. There is still some controversy in how this should be done.

@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Nov 12, 2017

Member

I would like to see CapturesInfo.CapturesTypes + CapturableInfo.CapturableTypes despite the redundancy it adds in names, but I'd be fine with CapturesInfo.CaptureTypes + CapturableInfo.CaptureTypes.

[15:03] <+penev> well this should be a quick'n'easy fix
[15:03] <+penev> someone just needs to do some renaming and a simple upgrade rule
[15:03] <+penev> and then repeat that like 20 times for all the traits

Member

penev92 commented Nov 12, 2017

I would like to see CapturesInfo.CapturesTypes + CapturableInfo.CapturableTypes despite the redundancy it adds in names, but I'd be fine with CapturesInfo.CaptureTypes + CapturableInfo.CaptureTypes.

[15:03] <+penev> well this should be a quick'n'easy fix
[15:03] <+penev> someone just needs to do some renaming and a simple upgrade rule
[15:03] <+penev> and then repeat that like 20 times for all the traits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment