Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gap generator/MGG render fog circle instead of shroud #15364

Open
AMHOL opened this issue Jul 21, 2018 · 4 comments

Comments

@AMHOL
Copy link

commented Jul 21, 2018

I remember seeing a discussion regarding this and have had a search but couldn't find a related PR or issue, so I thought I'd create one.

Currently the gap generator and MGG render shroud regardless of whether explored map is enabled or not, I think it would be better to render fog when fog of war is enabled, and shroud otherwise, the current implementation just gives away the position when explored map is enabled, or when fog is enabled and the area has been scouted.

I found the following links in which @pchote makes the suggestion, and, assuming I understand him correctly, I agree with most of his ideas on this.

The part I don't agree with, is actively hiding the building previews underneath, I think having them just instantly disappear when the gap generator is built / the MGG comes into range would be a dead giveaway, also what do you do in the scenario where a building preview under fog is part covered by the gap fog?

@pchote

This comment has been minimized.

Copy link
Member

commented Jul 22, 2018

what do you do in the scenario where a building preview under fog is part covered by the gap fog?

The same as we do when a building preview under fog is part covered by shroud - show the preview unless all the tiles in the footprint are covered by the gap-fog.

@GraionDilach

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2018

I hope this is suggested only as a mod balance suggestion and not as an engine feature replacement. The current GapGen mechanic is the WW accurate one.

@AMHOL

This comment has been minimized.

Copy link
Author

commented Jul 23, 2018

what do you do in the scenario where a building preview under fog is part covered by the gap fog?

The same as we do when a building preview under fog is part covered by shroud - show the preview unless all the tiles in the footprint are covered by the gap-fog.

I think that still opens the issue of buildings disappearing / appearing out of nowhere and giving it away, I think the best course of action in that scenario is to just show the frozen actor (or whatever it's called) preview, as happens now with buildings under fog that aren't actually there/in camo state.

@AMHOL

This comment has been minimized.

Copy link
Author

commented Jul 23, 2018

I hope this is suggested only as a mod balance suggestion and not as an engine feature replacement. The current GapGen mechanic is the WW accurate one.

I get that, yes it is a balance issue rather than a bug / not replicating the original properly, but as pchote said, the original didn't have fog of war so the behaviour was appropriate there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.