New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pillboxes give incorrect bounty #15585

Open
BlackenedRA opened this Issue Sep 3, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@BlackenedRA

BlackenedRA commented Sep 3, 2018

40 instead of 60.

@FrameLimiter

This comment has been minimized.

Show comment
Hide comment
@FrameLimiter

FrameLimiter Sep 3, 2018

Contributor

Looks like initial cargo is being ignored.
If you exit the pillbox, then re-enter it'll yield the correct bounty.

Contributor

FrameLimiter commented Sep 3, 2018

Looks like initial cargo is being ignored.
If you exit the pillbox, then re-enter it'll yield the correct bounty.

@abcdefg30 abcdefg30 added the Regression label Sep 4, 2018

@abcdefg30 abcdefg30 added this to the Next release milestone Sep 4, 2018

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Sep 7, 2018

Member

The issue here is that the condition that enables GivesBounty is not granted on actors that start as initial cargo. GrantConditionOnPrerequisite seems to rely on the actor being added to the world in order to register for notifications, so it makes sense that this would not work - what isn't clear is why this worked at all in previous releases.

Member

pchote commented Sep 7, 2018

The issue here is that the condition that enables GivesBounty is not granted on actors that start as initial cargo. GrantConditionOnPrerequisite seems to rely on the actor being added to the world in order to register for notifications, so it makes sense that this would not work - what isn't clear is why this worked at all in previous releases.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Sep 9, 2018

Member

what isn't clear is why this worked at all in previous releases.

Turns out that this is actually broken even worse on release-20180307 than on the current playtest: it only gives 40 credits, but the cash tick incorrectly shows 60. The changes required to fix this are high risk, so I don't think we can justify delaying the release further for this seeing as it is not a new regression.

Member

pchote commented Sep 9, 2018

what isn't clear is why this worked at all in previous releases.

Turns out that this is actually broken even worse on release-20180307 than on the current playtest: it only gives 40 credits, but the cash tick incorrectly shows 60. The changes required to fix this are high risk, so I don't think we can justify delaying the release further for this seeing as it is not a new regression.

@pchote pchote removed this from the Next release milestone Sep 9, 2018

@pchote pchote added Bug and removed Regression labels Sep 9, 2018

@pchote pchote changed the title from Pillboxes give incorrect bounty in playtest to Pillboxes give incorrect bounty Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment