New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly cancel/finish Child-/SequenceActivities instead of nulling them #15632

Open
reaperrr opened this Issue Sep 22, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@reaperrr
Contributor

reaperrr commented Sep 22, 2018

We have several bugs caused by unconditionally nulling or replacing activities, instead of properly canceling/finishing the current one first:

#9404
#10223
#10224
#15631
and probably quite a few more.

To fix this, we'll have to update the activity code to support propagating cancellation through activity sequences (including ChildActivity sequences).
For the sake of consistency and any potential cases that might need it, we should probably do the same for OnActorDispose introduced by #15622.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Sep 22, 2018

Contributor

Moving to Future milestone as, while Next+1 is probably too optimistic, it should be at least higher priority than a lot of other things, considering the number of bugs related to this.

Contributor

reaperrr commented Sep 22, 2018

Moving to Future milestone as, while Next+1 is probably too optimistic, it should be at least higher priority than a lot of other things, considering the number of bugs related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment