New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ip addresses from replay files #15647

Open
anvilvapre opened this Issue Sep 25, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@anvilvapre

anvilvapre commented Sep 25, 2018

privacy improvement, no need to store/save/write ip addresses in/to replay files.
and possibly other tokens like auth keys.

making it possible to publish them.

@Mailaender Mailaender added the Security label Sep 29, 2018

@matjaeck

This comment has been minimized.

Show comment
Hide comment
@matjaeck

matjaeck Oct 3, 2018

Contributor

Removing the IP sounds reasonable, however it is the only way to identify a non registered player. Authentication data is needed for registered players and including it should not be a privacy or security issue.

Contributor

matjaeck commented Oct 3, 2018

Removing the IP sounds reasonable, however it is the only way to identify a non registered player. Authentication data is needed for registered players and including it should not be a privacy or security issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment