New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target(Enemy|Ally)Units flags should be removed from UnitOrderTargeter ctor #15732

Open
pchote opened this Issue Oct 25, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@pchote
Member

pchote commented Oct 25, 2018

These no longer make sense now that many traits have moved over to yaml-exposed stance enums. These cases currently hardcode both flags to true, and then do their own enemy/ally filtering.

We can either change the constructor to accept a Stance targetableStances, or devolve all stance handling to the subclasses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment