New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CaptureCompleteTime to ProximityCapturable trait (like ExternalCapturable has) #15796

Open
avalach21 opened this Issue Nov 6, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@avalach21

avalach21 commented Nov 6, 2018

Hi guys. I was wondering if it would be possible to add a CaptureCompleteTime variable to the ProximityCapturable trait, similar to the way it works for ExternalCapture. As it works now, it seems that you can only have the target actor instantly captured if you are in proximity, but I would rather have it require you to be in the proximity for a certain amount of time (10 seconds or 30 seconds or whatever) and hold that proximity uncontested before capturing the actor. Kind of like a timed King of the Hill of a certain proximity around the actor to capture it. As a point of reference, I believe the capture points in Company of Heroes work like that...

Would obviously benefit from having a progress bar exactly the way an external capture does.

If this sort of functionality is already possible please enlighten me!!

@abcdefg30 abcdefg30 added the Feature label Nov 7, 2018

@abcdefg30

This comment has been minimized.

Member

abcdefg30 commented Nov 7, 2018

FWIW, ExternalCapturable was removed. (ProximityCapturable is not a "real" capture anyway, iirc.)

@avalach21

This comment has been minimized.

avalach21 commented Nov 7, 2018

Hi abcdefg30. thanks for the response :-) I am not sure what you mean though!

ExternalCapturable still seems to be an available trait ..?.. I understand that there are some rule changes coming for the way engis work in the base mod, but I hope there are no plans to remove the way capturing currently works so that modders can still use externalCapture style of capture if they wanted?

Beyond that, I am not sure what you mean by ProximityCapturable is not a "real" capture lol. What does that mean? I have tested it out on a mod map and it works just as expected... if a unit is in the defined proximity of the actor, then the actor is captured. I was hoping a time variable could be applied to this so that the capture isn't immediate.

@MustaphaTR

This comment has been minimized.

Member

MustaphaTR commented Nov 7, 2018

ExternalCapturable still seems to be an available trait ..?.. I understand that there are some rule changes coming for the way engis work in the base mod, but I hope there are no plans to remove the way capturing currently works so that modders can still use externalCapture style of capture if they wanted?

External Capture as a seperate trait is removed for the next release. Captures can handle everything now, including having a timer.

@avalach21

This comment has been minimized.

avalach21 commented Nov 7, 2018

ExternalCapturable still seems to be an available trait ..?.. I understand that there are some rule changes coming for the way engis work in the base mod, but I hope there are no plans to remove the way capturing currently works so that modders can still use externalCapture style of capture if they wanted?

External Capture as a seperate trait is removed for the next release. Captures can handle everything now, including having a timer.

Ahh I see.. awesome. Thank you for the clarification! Now I understand that ExternalCapturable functionality is being merged with Capture..

How about ProximityCapturable though? Is that going to be eliminated, or merged in some kind of way?

@abcdefg30

This comment has been minimized.

Member

abcdefg30 commented Nov 10, 2018

What I meant is that ProximityCapturable only uses parts of the normal capturing logic and does its own thing for the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment