New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aircraft fail to properly target a frozen actor after they detect it. #16010

Open
MustaphaTR opened this Issue Jan 6, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@MustaphaTR
Copy link
Member

MustaphaTR commented Jan 6, 2019

Can be easily reproduced with RA Hinds, target a frozen actor, when it detects the frozen actor it stops instead of moving in range and fire.

@pchote pchote added this to the Next Release milestone Jan 6, 2019

@pchote pchote added the Regression label Jan 6, 2019

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 6, 2019

Only affects helicopters - HeliAttack was forgotten about (because I was expecting it would go away).

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 6, 2019

HeliAttack is a bit of a mess because of the custom move-to-last position fallback. It may be worth trying to go all in and fix #10223 instead of bodging it further.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 13, 2019

As discussed on IRC and discord, the problem here goes a lot deeper than just the Actor ⇆ FrozenActor transition for helicopters. #15866 forgot about (and in some cases broke) everything that wasn't FrozenUnderFog.

https://github.com/pchote/OpenRA/tree/restore-hidden-targets is tracking my current progress on fixing all this properly, which unfortunately means it is much larger than the original #15866. I'll try to give proper context for each group of commits when its ready to PR, so it shouldn't be as intimidating as it might first look.

As a nice side effect, this has forced a solution to the MoveAdacentTo target line weirdness, which was the last big blocker for fixing #2598. It may be feasible to resurrect #14384 for Next + 1 after this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment