New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing debug msgs for q and w shortcuts #16148

Open
Punsho opened this Issue Feb 1, 2019 · 17 comments

Comments

Projects
None yet
6 participants
@Punsho
Copy link

Punsho commented Feb 1, 2019

I personally use 'select unit by type' all the time as it is one of the best tools for unit micro management thus I get constant spam of msgs and chat noise
screenshot 2019-02-01 at 23 56 57
this makes it a lot harder harder to notice msgs written by spectators and other players as well as reading missed ones, I'd like it removed as it serves no significant purpose

@netnazgul

This comment has been minimized.

Copy link
Contributor

netnazgul commented Feb 3, 2019

Yes, I'd long since wanted something done about that. Though some visual/sound confirmation should still appear while pressing the key.

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Feb 3, 2019

The issue I see is that the hotkey for Select units by type does two different things depending on your current selection: If there are other, not selected units of same type on the screen, it will select all units of this type across screen. If all units of this type on the screen are selected, it will select across map.

This is not obvious so this debug information is IMO required.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Feb 3, 2019

There should be an old issue somewhere about putting these messages in their own notification area, like RA2 did. I'm not sure the best keywords to try and find it again, however.

@Punsho

This comment has been minimized.

Copy link
Author

Punsho commented Feb 3, 2019

Selection rules are clear, I personally never check that msg as I know when I select all units by type on the map and when not

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Feb 3, 2019

RA2 didn't have separate notification area though.

@Punsho

This comment has been minimized.

Copy link
Author

Punsho commented Feb 3, 2019

I would love if it would be more consistent. When you press the button once it would select all units on screen and when twice all on the map without any arbitrary rules that are in now

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Feb 3, 2019

Actually, that's what RA2 did - I thought that's how it acts already.

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Feb 3, 2019

Removing debug msgs for q and w shortcuts

Just to clarify, this means Remove debug messages for hotkeys Select units by type / Select all combat units.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Feb 3, 2019

See #3278 / #6400 / #6376 etc. There is an accessibility angle to consider here.

@Punsho

This comment has been minimized.

Copy link
Author

Punsho commented Feb 4, 2019

Yeah, it is a different topic. Streamlining the selection would remove the need for these notifications entirely and I believe that it would be easy and quick to do as opposed to making everything post debug msgs

@Punsho

This comment has been minimized.

Copy link
Author

Punsho commented Feb 4, 2019

Also if someone made everything post debug msgs I think that this one would just clutter the chat and people would ask again for it's removal

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Feb 4, 2019

If someone would made everything posting debug commands then those would be tied to a checkbox within Options anyway.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Feb 4, 2019

The idea was that these messages would be written to their own status line, separate to the chat and without a history scrollback.

@dragunoff

This comment has been minimized.

Copy link
Contributor

dragunoff commented Feb 4, 2019

+1 for moving that kind of messages to a separate tray and +1 for adding support for text notifications when sound isn't available.

@Punsho What do you mean by "Streamlining the selection"?

@Punsho

This comment has been minimized.

Copy link
Author

Punsho commented Feb 4, 2019

@dragunoff
Currently selection works unreliably as when you click a button once, it will select all units of that type on screen but if all of those units are already selected it's going to select globally, this is an arbitrary rule. IMO in that case it should not select anything

@dragunoff

This comment has been minimized.

Copy link
Contributor

dragunoff commented Feb 4, 2019

@Punsho
I think this is a very clear rule and I always found the selection functionality quite intuitive but I think I can see your pain point here. Anyway this should be the subject of a separate issue.

@Punsho

This comment has been minimized.

Copy link
Author

Punsho commented Feb 4, 2019

It is very clear but it is hard to think about in the heat of battle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment