New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unit Ready" voice notification is silent sometimes #16195

Open
netnazgul opened this Issue Feb 10, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@netnazgul
Copy link
Contributor

netnazgul commented Feb 10, 2019

Second part of #16117 that feels like a regression.

It is not consistent, but generally you can have "Unit Ready" not voiced when for example producing 100 rifle infantry in a row - it is produced for 4-5 rifles, then is silent for the next 4-5, then sounds again for consequent ones.

@pchote pchote added the Regression label Feb 10, 2019

@pchote pchote added this to the Next Release milestone Feb 10, 2019

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Feb 10, 2019

This can be reproduced by playing the attached replay with || p.PlayerName == "BrotherPun" added to the player check in PlayPredefined. The lack of notifications can be seen about 2.5 minutes in.

UnitReady.orarep.zip

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Feb 10, 2019

Ok, this one is really silly. The rate limit currently doesn't discriminate players, so if anybody in the game has just built something it won't play for you.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Feb 10, 2019

The simplest/safest fix now is probably to revert/remove the RateLimit notification key. We got the main benefit from the rate limiting in a different way in #16083, and #16034 made the most of the basic plumbing that the original rate limit PR added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment