Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenRA starts only if localSupportDir exists on Windows 10 Build 18346 #16267

Open
QuadlessPyjack opened this Issue Mar 4, 2019 · 5 comments

Comments

Projects
None yet
6 participants
@QuadlessPyjack
Copy link

QuadlessPyjack commented Mar 4, 2019

Issue Summary

On first install, game hangs on start because it can't write to C:\Users<username>\OneDrive\Documents

System Information

  • Operating System: Windows 10 Pro Build 18346.19h1
  • .NET / Mono Version: Latest
  • OpenRA Version: latest master branch build as well as bleeding branch build at commit: 7d72aae
  • Mod: All mods (anything trying to write to [username]\OneDrive\Documents will cause this error)

Additional Information:

  • Steps to reproduce

    1. Download and build master release
    2. Start game from VS2017 with debugger attached and relevant System.IO exceptions enabled
    3. The logging system will throw FileIO exceptions in cascade for each [CHANNEL].log file it tries to create
      4. Downloaded game content extraction will fail with FileIO exceptions
  • Logs
    debug.log
    Please note that the debug.log file had to be manually created first. Furthermore, it seems that not all IO exceptions were logged. This could be a breaking change caused by Microsoft when they moved the Documents folder inside OneDrive. Getting the Documents folder from the C# API will return [Username]/OneDrive/Documents. Now I know this is an Insider Build of Windows so it may not be on your priority list for support and I can totally understand that, however, it might be of great use for others like me to know that creating a "Support" folder inside GameDir solves this issue.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Mar 4, 2019

Is this a new preview-build windows feature (note: I don't use Windows)? I haven't seen any reports of this kind of issue before for OpenRA, and searching online for windows onedrive documents just gives a bunch of marketing for MS Office.

@QuadlessPyjack

This comment has been minimized.

Copy link
Author

QuadlessPyjack commented Mar 5, 2019

I'm not sure exactly from what build onward Microsoft decided to backup the user folder by moving folders such as Documents inside OneDrive but its been like this since at least the Fast branch of Insider builds from November 2018 afaik. Can't remember a specific build version unfortunately.

annotation 2019-03-05 020956

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Mar 5, 2019

Doesn't look new to me.

https://support.office.com/en-us/article/files-save-to-onedrive-by-default-in-windows-10-33da0077-770c-4bda-b61e-8c8e8ca70ac7

I just guess noone uses OneDrive and this is basically just another reason to move out OpenRA stuff from Documents.

EDIT: Ah, the real issue here is OneDrive folder protection: https://www.howtogeek.com/363720/how-to-enable-microsofts-new-onedrive-folder-protection-in-windows/

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Mar 5, 2019

@pchote As far as I can tell going by my own user data, newer games seemingly store their equivalents of everything except content (which is normally put into the game directory directly) in

C:\Users\username\AppData\Local\gamename

Only talking about Win10 of course. Win 8(.1) might already have that AppData folder too, but I have my doubts about Win7 and Vista, so we may have no other choice but to differentiate between Win10 and legacy Windows versions.

@MustaphaTR

This comment has been minimized.

Copy link
Member

MustaphaTR commented Mar 6, 2019

AppData definetly exists in Win7, and i don't think we care about anything older.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.