Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateEffectWarhead does not properly account for untargetable actors #16308

Open
reaperrr opened this Issue Mar 14, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@reaperrr
Copy link
Contributor

reaperrr commented Mar 14, 2019

No visual impact explosion. Only smudge is spawned.
Probably a regression.

If debugging and fixing it turns out to be easy, maybe sneak it into release.

CreateEffectWarhead currently considers actors 'invalid' (and therefore doesn't trigger) not only if their target types are invalid, but also if they have no (enabled) targetables at all.
However, in that case it would often actually give better results if those untargetable actors were instead simply ignored completely, so the terrain below can be taken into consideration instead.

@reaperrr reaperrr added this to the Next Release milestone Mar 14, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Mar 14, 2019

Strangely enough, this seems to only affect the first plane of an airstrike.

@reaperrr reaperrr removed this from the Next Release milestone Mar 14, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Mar 14, 2019

It looks like setting ImpactActors: false on the effect warhead helps, but that would break the ground/water separation.

The fact that it helps indicates that there's an actor in the impact area that is considered invalid, and the only logical candidate is the camera actor.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Mar 14, 2019

I think I figured out what the problem is:
If the 'y' value of SquadOffset on AirstrikePower is zero and the squad is 3+ in size, 2 planes will fly on the exact same WPos, meaning they'll be shot down and crash at the exact same tick and WPos too, invalidating each other's explosion (husks aren't targetable => invalid target).

If that's the case, I guess we should (at least optionally, perhaps even by default) completely ignore (as if they weren't even there) actors without (enabled) targetables in CreateEffectWarhead, rather than considering them an 'invalid target'.

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Mar 15, 2019

Can you confirm it's a regression?

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Mar 15, 2019

No, it actually isn't. I'll remove the label.

@reaperrr reaperrr removed the Regression label Mar 15, 2019

@reaperrr reaperrr changed the title RA Badger bombers don't explode when shot down CreateEffectWarhead does not properly account for untargetable actors Mar 15, 2019

@reaperrr reaperrr added Limitation and removed Red Alert labels Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.