Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aircraft refactor #16338

Open
reaperrr opened this Issue Mar 22, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@reaperrr
Copy link
Contributor

reaperrr commented Mar 22, 2019

This is a large untertaking spanning over several PRs, many of which depend on others, and sometimes the review process reveals things that are better split off/taken care of first, before continuing on a specific PR.

Out of the currently open PRs, the order of reviewing/merging is supposed to be:

Planned changes that I haven't finished yet:

  • Refactor Reservable into Dock, with various improvements coming along with it (locally pretty much done)
  • Move all of Aircraft's resupply handling to a central ResupplyManager that I plan to split from Repairable (the latter part is locally done, the former not started yet, but shouldn't be hard)

@reaperrr reaperrr added the Meta label Mar 22, 2019

@reaperrr reaperrr added this to the Next Release milestone Mar 22, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Mar 22, 2019

Ping @obrakmann

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Apr 2, 2019

Note: I haven't decided yet, but I might split off more of the activity merging from #15803 like I did with #16241, if I get the feeling that issues with #15873 block progress for too long.

Would appreciate this for reviewing ingame.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Apr 11, 2019

Updated.

@reaperrr reaperrr referenced this issue Apr 12, 2019

Open

Resupply refactor roadmap #16403

0 of 5 tasks complete
@tovl

This comment has been minimized.

Copy link
Contributor

tovl commented Apr 12, 2019

It might be a good idea to take #16315 into account here as well. The changes to Land and HeliLand there will make them more similar to each other so #16365 might want to depend on that.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Apr 13, 2019

Makes sense, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.