Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AttackBomber #16690

Open
reaperrr opened this issue Jun 11, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@reaperrr
Copy link
Contributor

commented Jun 11, 2019

AttackBomber has always been a somewhat hacky, hardcoded trait only serving to make airstrike superweapons work.

It shouldn't be too hard to support the AttackBomber behavior via AttackAircraft, without the limitations and hardcoding.

@reaperrr reaperrr added the Refactor label Jun 11, 2019

@GraionDilach

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Already done before - that's why I noticed #15948. Although I haven't touched it for a while and with all the activity stuff ongoing, I expect it need a complete rewire by now (there were some nasty hacks which I had to do anyway to get it working years ago, involving requeueing activities, specialcasing choppers and whatnot).

I do plan to return to this though because this had multiple runs from the get go and I guess you can take some hints from it.

https://github.com/AttacqueSuperior/Engine/blob/master/OpenRA.Mods.AS/Traits/SupportPowers/AirstrikePowerAS.cs
https://github.com/AttacqueSuperior/Engine/blob/master/OpenRA.Mods.AS/Effects/AirstrikePowerASEffect.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.