Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Depot bug: new rallypoint movecmd even thought other movecmd exists #16761

Closed
fruestueck opened this issue Jul 9, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@fruestueck
Copy link
Contributor

commented Jul 9, 2019

After a vehicle is repaired on the service depot a new move command is added to the bottom of the units move cmd list, even if it already has other commands.
This results in vehicles moving back to the rallypoint (after individual move cmds where executed).

Tested with TS service depot and RA service depot on bleed.

Regression PR #13093
openra_bug_servicedepot

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

I had already fixed this locally, but then dropped that because it would break the guarantee of "first move off host when resupply is cancelled to make sure we don't stay on host when the new order is not a move order" which was the reason why this part of the code was introduced to begin with.
As far as I can tell, we can't have both the guarantee that the actor leaves the host AND make it as responsive as requested in this issue without making things horribly complicated, which I'm not motivated to do (especially so close to a playtest).
Personally I agree this is a bigger issue (and more annoying) than the risk of actors staying on the host when the resupply was cancelled via a non-move order, but first I want @pchote' opinion so I won't have to fix/revert/change things multiple times.

@pchote

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

The simple fix here is to check if NextActivity is a Move and skip the nudge.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

My point is that this presumably won't trigger for activities that use MoveTo, MoveAdjacentTo, MoveWithinRange or anything of that sort, but yeah, I guess it'll work for normal "Move" orders.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

#16721 should fix this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.