Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundOnDamageTransition has legacy cruft. #16763

Open
GraionDilach opened this issue Jul 10, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@GraionDilach
Copy link
Contributor

commented Jul 10, 2019

It is hardcoded to play sounds on both switching around Heavy damagestate and destroyed.

For the latter part, we already have DeathSounds, so that functionality can be axed. For the former, conditions and damagetype support would be nice.

@abcdefg30 abcdefg30 added the Refactor label Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.