Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace or remove actors of non-existing players when saving in the editor #16868

Open
abcdefg30 opened this issue Jul 31, 2019 · 1 comment

Comments

@abcdefg30
Copy link
Member

commented Jul 31, 2019

As seen in #16867 you can easily place a new mpspawn and a few actors assigned to that player, then remove the spawn and the map will crash when loading the editor. Just remapping the owner of such units to an existing player (e.g. "Neutral" if it exists) on map save (to avoid losing actors when moving a spawn) sounds like a good idea to me. We can also consider removing such actors. (Perhaps this can be done if there are no valid players defined.) Opinions?

@GraionDilach

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

IIRC the classic games removed actors of nonexistant owners on game load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.