Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savegames do not grey out when the map is not found #17070

Open
abcdefg30 opened this issue Sep 9, 2019 · 7 comments

Comments

@abcdefg30
Copy link
Member

commented Sep 9, 2019

or display any other indication why nothing happens when you press the load button.

@PurityLake

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

I have suggestions:

  • tooltip on hover
  • a symbol signifying missing map would be preferable to greying out as it is less ambiguous
  • dialogue box if load is pressed or eliminate the load button altogether if clicked

What are other's opinions on this?

@dragunoff

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

I think one possible route to go here is to build a savegame browser similar to the replay browser. Virtually all of the UI in the replay browser can be used for saved games - viewing the map and players, filtering the games, renaming, deleting.

@pchote

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Savegames only work in singleplayer. Why would we need to filter by players?

@PurityLake

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

I agree with pchote, for single-player player filters don't count unless you want to sort by AI which I'm not sure many people would but I feel that would be a separate issue

@PurityLake

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Should there be a mix of the 3 suggestions I made? If so I'll begin work on it as soon as possible

@dragunoff

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Savegames only work in singleplayer. Why would we need to filter by players?

Yes, most of the filters don't make sense. I was talking more about the map preview and the general layout.

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

👍 to making the save game list more similar to the replay browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.