Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility command --check-yaml crashes #17202

Open
Punsho opened this issue Oct 8, 2019 · 4 comments · May be fixed by #17203

Comments

@Punsho
Copy link
Contributor

commented Oct 8, 2019

When I make maps I always run this utility command on the newest bleed version. When I tried it, it crashed with this message. That command does not crash for other RA versions (release and playtest) on my map

OpenRA.Utility(1,1): Error: Missing Type: EditorActionManagerInfo
OpenRA.Utility(1,1): Error: Failed with exception: System.AggregateException: One or more errors occurred. ---> System.NullReferenceException: Object reference not set to an instance of an object
  at OpenRA.FieldLoader.Load (System.Object self, OpenRA.MiniYaml my) [0x00000] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.ActorInfo.LoadTraitInfo (OpenRA.ObjectCreator creator, System.String traitName, OpenRA.MiniYaml my) [0x00042] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.ActorInfo..ctor (OpenRA.ObjectCreator creator, System.String name, OpenRA.MiniYaml node) [0x0004b] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Ruleset+<>c__DisplayClass12_0.<LoadDefaults>b__1 (OpenRA.MiniYamlNode k) [0x00016] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Exts.ToDictionaryWithConflictLog[TSource,TKey,TElement] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] keySelector, System.Func`2[T,TResult] elementSelector, System.String debugName, System.Func`2[T,TResult] logKey, System.Func`2[T,TResult] logValue) [0x0008e] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Ruleset.MergeOrDefault[T] (System.String name, OpenRA.FileSystem.IReadOnlyFileSystem fileSystem, System.Collections.Generic.IEnumerable`1[T] files, OpenRA.MiniYaml additional, OpenRA.IReadOnlyDictionary`2[TKey,TValue] defaults, System.Func`2[T,TResult] makeObject, System.Func`2[T,TResult] filterNode) [0x0006e] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Ruleset+<>c__DisplayClass12_0.<LoadDefaults>b__0 () [0x00000] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at System.Threading.Tasks.Task.InnerInvoke () [0x0000f] in <71f4e3d7d65e42b0a699d02e59766d3c>:0 
  at System.Threading.Tasks.Task.Execute () [0x00010] in <71f4e3d7d65e42b0a699d02e59766d3c>:0 
   --- End of inner exception stack trace ---
  at System.Threading.Tasks.Task.ThrowIfExceptional (System.Boolean includeTaskCanceledExceptions) [0x00011] in <71f4e3d7d65e42b0a699d02e59766d3c>:0 
  at System.Threading.Tasks.Task.Wait (System.Int32 millisecondsTimeout, System.Threading.CancellationToken cancellationToken) [0x00043] in <71f4e3d7d65e42b0a699d02e59766d3c>:0 
  at System.Threading.Tasks.Task.Wait (System.Int32 millisecondsTimeout) [0x00000] in <71f4e3d7d65e42b0a699d02e59766d3c>:0 
  at OpenRA.Ruleset.LoadDefaults (OpenRA.ModData modData) [0x00075] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.ModData.<.ctor>b__30_3 () [0x00000] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at System.Lazy`1[T].CreateValue () [0x00060] in <71f4e3d7d65e42b0a699d02e59766d3c>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Lazy`1[T].get_Value () [0x00020] in <71f4e3d7d65e42b0a699d02e59766d3c>:0 
  at OpenRA.ModData.get_DefaultRules () [0x00000] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Ruleset.LoadDefaultsForTileSet (OpenRA.ModData modData, System.String tileSet) [0x00000] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Map.PostInit () [0x00078] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Map..ctor (OpenRA.ModData modData, OpenRA.FileSystem.IReadOnlyPackage package) [0x0039b] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Mods.Common.UtilityCommands.CheckYaml.OpenRA.IUtilityCommand.Run (OpenRA.Utility utility, System.String[] args) [0x00165] in <c20bc88f1d7b4a3bb9778af5f76d4e82>:0 
---> (Inner Exception #0) System.NullReferenceException: Object reference not set to an instance of an object
  at OpenRA.FieldLoader.Load (System.Object self, OpenRA.MiniYaml my) [0x00000] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.ActorInfo.LoadTraitInfo (OpenRA.ObjectCreator creator, System.String traitName, OpenRA.MiniYaml my) [0x00042] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.ActorInfo..ctor (OpenRA.ObjectCreator creator, System.String name, OpenRA.MiniYaml node) [0x0004b] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Ruleset+<>c__DisplayClass12_0.<LoadDefaults>b__1 (OpenRA.MiniYamlNode k) [0x00016] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Exts.ToDictionaryWithConflictLog[TSource,TKey,TElement] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] keySelector, System.Func`2[T,TResult] elementSelector, System.String debugName, System.Func`2[T,TResult] logKey, System.Func`2[T,TResult] logValue) [0x0008e] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Ruleset.MergeOrDefault[T] (System.String name, OpenRA.FileSystem.IReadOnlyFileSystem fileSystem, System.Collections.Generic.IEnumerable`1[T] files, OpenRA.MiniYaml additional, OpenRA.IReadOnlyDictionary`2[TKey,TValue] defaults, System.Func`2[T,TResult] makeObject, System.Func`2[T,TResult] filterNode) [0x0006e] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at OpenRA.Ruleset+<>c__DisplayClass12_0.<LoadDefaults>b__0 () [0x00000] in <4f4232c09ba042bc87d8d1ed0743357b>:0 
  at System.Threading.Tasks.Task.InnerInvoke () [0x0000f] in <71f4e3d7d65e42b0a699d02e59766d3c>:0 
  at System.Threading.Tasks.Task.Execute () [0x00010] in <71f4e3d7d65e42b0a699d02e59766d3c>:0 <---
@pchote pchote added this to the Next+1 milestone Oct 8, 2019
@pchote pchote added the Regression label Oct 8, 2019
@Punsho

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

This definitely be on Next Release milestone. It is a crucial tool for modders

@pchote

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

This isn't going to affect the next release. #16772 will be in Next + 1.

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

@Punsho Could you attach the map you have run the command against?

@abcdefg30

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Error: Missing Type: EditorActionManagerInfo actually suggests the game does not recognize the EditorActionManager trait, which hints at a failed/missing compilation.

@abcdefg30 abcdefg30 referenced a pull request that will close this issue Oct 8, 2019
@abcdefg30 abcdefg30 removed this from the Next+1 milestone Oct 8, 2019
@abcdefg30 abcdefg30 added Crash Utility and removed Regression labels Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.