Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithPermanentInjury should be deleted in favor of a GrantConditionOnDamageState + WithInfantryBody combination. #17261

Open
GraionDilach opened this issue Oct 20, 2019 · 2 comments · May be fixed by #17264
Labels

Comments

@GraionDilach
Copy link
Contributor

@GraionDilach GraionDilach commented Oct 20, 2019

Cyborgs in TS/RA2 were in prone state with the prone speed multiplier applied to them when injured. This is not doable in this state.

@abcdefg30 abcdefg30 added the Feature label Oct 20, 2019
@reaperrr

This comment has been minimized.

Copy link
Contributor

@reaperrr reaperrr commented Oct 20, 2019

IMO WithPermanentInjury should just go away. We already have GrantConditionOnDamageState and GrantConditionOnHealth, and both have a GrantPermanently flag.

Basically, I'm inclined to say it should already be possible to replicate the original Cyborg behavior entirely via conditions, without WPI.

@GraionDilach

This comment has been minimized.

Copy link
Contributor Author

@GraionDilach GraionDilach commented Oct 20, 2019

Even better.

@GraionDilach GraionDilach changed the title WithPermanentInjury should provide a condition instead of being a mere infantry sequence modifier. WithPermanentInjury should be deleted in favor of a GrantConditionOnDamageState + WithInfantryBody combination. Oct 20, 2019
@reaperrr reaperrr referenced a pull request that will close this issue Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.