Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual indicator when sound is muted #17549

Open
dragunoff opened this issue Jan 3, 2020 · 8 comments
Open

Add visual indicator when sound is muted #17549

dragunoff opened this issue Jan 3, 2020 · 8 comments
Labels

Comments

@dragunoff
Copy link
Contributor

@dragunoff dragunoff commented Jan 3, 2020

The hotkey to mute sounds could be pressed accidentally and in the heat of battle the player might not notice the chat notification and wonder why the sound is off. Displaying a persistent visual indicator would be helpful to quickly assert whether the sound has been muted.

See #17482 (comment)

@pchote

This comment has been minimized.

Copy link
Member

@pchote pchote commented Jan 3, 2020

The chat notification is also currently displayed in the wrong colour.

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

@dragunoff dragunoff commented Jan 3, 2020

#6400 is related

@pchote

This comment has been minimized.

Copy link
Member

@pchote pchote commented Jan 3, 2020

If we can quickly agree on a size and location for the indicator I will be able to add the artwork as part of #17494 etc and save a redundant set of png sheets from going into the git history.

@teinarss

This comment has been minimized.

Copy link
Contributor

@teinarss teinarss commented Jan 3, 2020

Top right corner, left of the minimap? Something like this https://commons.wikimedia.org/wiki/File:Mute_Icon.svg white color and black borders would make it easy to see.

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

@dragunoff dragunoff commented Jan 3, 2020

Some mockups, in-game:
openra-audio-muted-indicator--cnc-game
openra-audio-muted-indicator--ra-game

In replays:
openra-audio-muted-indicator--cnc-replay
openra-audio-muted-indicator--ra-replay

Next to the sidebar:
openra-audio-muted-indicator--cnc-game-sidebar
openra-audio-muted-indicator--ra-game-sidebar

My thoughts:

  • I think it looks better in the middle of the screen as it doesn't clash with other parts of the UI.
  • Adding a text label makes it clearer and more visible
  • A shadow/stroke is needed for the notification to stand out against the background
  • The size and positioning can be further adjusted, this is just a quick mock-up. Here is the SVG I put together if anyone wants to play with it: https://drive.google.com/open?id=1pnBGTnvOWqdLleS71fztBut3OA1R8siV
@abcdefg30

This comment has been minimized.

Copy link
Member

@abcdefg30 abcdefg30 commented Jan 3, 2020

Putting it in the top mid will conflict with our Lua mission text.

@pchote

This comment has been minimized.

Copy link
Member

@pchote pchote commented Jan 3, 2020

Aligning it to the right is probably our best bet for avoiding overlaps with other text. We may have to omit the text to make sure it doesn't clash at the smallest screen sizes. Bottom left above the command bar (overlapping the perf graph if that is enabled) might also work, and would let us keep the label.

@pchote

This comment has been minimized.

Copy link
Member

@pchote pchote commented Jan 8, 2020

Added glyph to #17494 and #17495.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.