Fix smudges spawning/growing on cells occupied by structures or vehicles #11592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to prevent smudges to spawn below buildings, vehicles etc.
Also walls, trees and husks in most cases. Note: Differences between warheads are intentional. Note2: Some smudge WHs were removed instead when the weapon was purely anti-air or anti-water.
Also trees, husks and creeps (dinos and visceroids) in most cases. Exceptions are intentional.
Exceptions are intentional.
|
Note: Would be nice to get this in before the playtest, I think it's some nice polish with little regression risk. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the
LeaveSmudgewarhead checks the target type(s) of actors on affected cells, rather than only caring about the terrain.This can be used to prevent craters or scorches spawning and growing under buildings and vehicles, which matches the behavior in the originals and looks more realistic anyway.
Also, but not related, the explosion sound of TD artillery weapon was not playing because it was listed as uppercase, this is fixed as well.
Fixes #6464.