Fix mouse input breakage #11941
Merged
Fix mouse input breakage #11941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to regress the scroll-cursor while drag-scrolling. If you could show that (or even just the default cursor, or anything else but the order cursor) while outside the deadzone it would make the two modes feel more consistent. The "bug" from #11849 is a non-issue for me because the action that happens matches the cursor in the joystick mode. |
|
Looks good to me. 👍 / ✅ |
| @@ -286,7 +286,8 @@ public override bool HandleMouseInput(MouseInput mi) | |||
|
|
|||
| if (scrollType == MouseScrollType.Standard || scrollType == MouseScrollType.Inverted) | |||
| { | |||
| if (mi.Event == MouseInputEvent.Move) | |||
| if (mi.Event == MouseInputEvent.Move && | |||
| (isStandardScrolling || (Viewport.LastMousePos - mi.Location).Length > Game.Settings.Game.MouseScrollDeadzone)) | |||
There was a problem hiding this comment.
This needs to be relative to the start of the move, not the last pos. If you move your mouse slow enough it will never trigger.
obrakmann
force-pushed
the
fix11940-std-scrolling-deadzone
branch
from
64e51a5
to
5ac3d1a
Compare
|
Updated. |
This re-introduces a bug where releasing the RMB button causes an order to be generated for the selected units if the user didn't move their mouse just prior.
... when edge scrolling was also disabled.
obrakmann
force-pushed
the
fix11940-std-scrolling-deadzone
branch
from
5ac3d1a
to
f554531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-introduces the bug from #11849 for joystick-scrolling and fixes #11940 for standard-scrolling.