Replaced civillians with Technicians when building sold #12174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
^ScienceBuilding should also emit "technicians" instead of "civilians" ... and we could make this a bit more interesting by having ^CivBuilding emit "civs" ... when they are destroyed ... with "EjectOnDeath:" so we can actually still see "Civilians" ingame |
reaperrr
reviewed
Oct 14, 2016
| @@ -466,7 +466,7 @@ | |||
| ExternalCapturable: | |||
| ExternalCapturableBar: | |||
| EmitInfantryOnSell: | |||
| ActorTypes: e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,c1,c2,c3,c4,c5,c6,c7,c8,c9,c10,e6,e6,e6,e6,e6 | |||
| ActorTypes: e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,e1,tecn,tecn,tecn,tecn,tecn,tecn,tecn,tecn,tecn,tecn,e6,e6,e6,e6,e6 | |||
There was a problem hiding this comment.
This list now contains 15x e1, 10x tecn and 5x e6, so you can actually shorten it drastically to e1,e1,e1,tecn,tecn,e6 to get the same probability ratio.
Although on that note, only construction yards should emit e6, so maybe we should remove it here and only add it on FACT.
|
Changes made. I think that the ^CivBuildings emitting civs on destruction should be raised as a separate issue as changes need to be made to the EjectOnDeath trait. |
reaperrr
approved these changes
Oct 20, 2016
|
👍 |
|
👍 / ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12122.