New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forward movement support to GravityBomb #12606

Merged
merged 4 commits into from Apr 11, 2017

Conversation

Projects
None yet
5 participants
@reaperrr
Contributor

reaperrr commented Jan 22, 2017

Used to make TS Orca Bomber bombs behave more like in the original.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jan 22, 2017

Member

@Mailaender: what's going on with these "in progress" labels?

Member

pchote commented Jan 22, 2017

@Mailaender: what's going on with these "in progress" labels?

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Jan 22, 2017

Contributor

I'd like to see a ForwardAcceleration tag along with this.

Contributor

GraionDilach commented Jan 22, 2017

I'd like to see a ForwardAcceleration tag along with this.

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Jan 22, 2017

Member

@Mailaender: what's going on with these "in progress" labels?

I was interested in the https://waffle.io/OpenRA/OpenRA/metrics for this repository. This must have activated some other crap. Sorry.

Member

Mailaender commented Jan 22, 2017

@Mailaender: what's going on with these "in progress" labels?

I was interested in the https://waffle.io/OpenRA/OpenRA/metrics for this repository. This must have activated some other crap. Sorry.

@Mailaender Mailaender removed the in progress label Jan 22, 2017

@pchote

Confirmed that this makes the bombs behave more like the original. Our drop rate is still much faster (a factor of two or so) than the original... worth fixing that here too?

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jan 29, 2017

Contributor

Updated.

Tweaked Orca bomb a bit more, too. It might need some more fine-tuning, but I think it's good enough for now.

Contributor

reaperrr commented Jan 29, 2017

Updated.

Tweaked Orca bomb a bit more, too. It might need some more fine-tuning, but I think it's good enough for now.

@pchote

Sorry to be a pain, but I'd like you to tweak the plumbing a bit more to make this work like other offsets:

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Mar 4, 2017

Contributor

I haven't forgotten about this, I'll try to adress all comments soon™.

Contributor

reaperrr commented Mar 4, 2017

I haven't forgotten about this, I'll try to adress all comments soon™.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Mar 29, 2017

Contributor

Rebased and updated.

Now uses args.Facing and reads forward, right, up from the exposed fields and then converts them internally.
Also, now first updates position and then adds acceleration for next tick (otherwise launch velocity would already be Velocity + Acceleration).

Contributor

reaperrr commented Mar 29, 2017

Rebased and updated.

Now uses args.Facing and reads forward, right, up from the exposed fields and then converts them internally.
Also, now first updates position and then adds acceleration for next tick (otherwise launch velocity would already be Velocity + Acceleration).

PR updated

@reaperrr reaperrr added this to the Tiberian Sun Public Alpha milestone Apr 4, 2017

@pchote

pchote approved these changes Apr 10, 2017

@pchote pchote added the PR: Needs +2 label Apr 10, 2017

@abcdefg30 abcdefg30 merged commit e37667e into OpenRA:bleed Apr 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Apr 11, 2017

@reaperrr reaperrr deleted the reaperrr:forward-bombs2 branch Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment