Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on Maxmind.GeoIP and Newtonsoft.Json #12702

Merged
merged 1 commit into from Feb 11, 2017

Conversation

Mailaender
Copy link
Member

as suggested in #12132 (comment) the dependency on those libraries was a bit over the top as we only use a very tiny subset for our GeoIP lookups.

@Mailaender Mailaender changed the title Updated to Maxmind.Db 2.1.2 dropping Maxmind.GeoIP and Newtonsoft.Json dependencies Updated to Maxmind.Db 2.1.3 dropping Maxmind.GeoIP and Newtonsoft.Json dependencies Feb 5, 2017
@Mailaender
Copy link
Member Author

I just realized that version 2.1.3 is available already and I need help with the PowerShell scripts.

@Mailaender Mailaender changed the title Updated to Maxmind.Db 2.1.3 dropping Maxmind.GeoIP and Newtonsoft.Json dependencies Drop dependency on Maxmind.GeoIP and Newtonsoft.Json Feb 5, 2017
@Mailaender
Copy link
Member Author

Avoided the update as suggested by @rapgro and @pchote to avoid the .NET core dependency.

@pchote pchote added this to the Next Release milestone Feb 10, 2017
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised on OSX

@abcdefg30 abcdefg30 merged commit b26b7b9 into OpenRA:bleed Feb 11, 2017
@abcdefg30
Copy link
Member

Changelog

@Mailaender Mailaender deleted the maxmind.db-2.1.2 branch February 11, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants