New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atreides05 #12785

Merged
merged 1 commit into from Apr 12, 2017

Conversation

Projects
None yet
6 participants
@abcdefg30
Member

abcdefg30 commented Feb 15, 2017

Depends on #12784.
I also still need to get the colors for Smugglers and Mercenaries (which I'll do tomorrow).

@Micr0Bit

Micr0Bit approved these changes Feb 15, 2017 edited

theres one thing i dont like ... that units dive into the shroud on top and bottom edge of the map

but i assume that has nothing to do with the mission itself ?

regardless, i finished the mission without any technical problems 👍

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Feb 16, 2017

Member

I used DDDD00 for mercenaries and 542209 for smugglers in my older maps (and Ord4 for smugglers too).

Member

MustaphaTR commented Feb 16, 2017

I used DDDD00 for mercenaries and 542209 for smugglers in my older maps (and Ord4 for smugglers too).

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Feb 16, 2017

Member

We can't build combat tank from Starport.

Also i like the fact that Contrabants contain Ordos Tanks not Atreides. This wasn't the case in original even tho it was possible.

I feel like it would be better if Combat Tank we can buy from Smugglers was Ordos too, it is a Smugglers Starport. We can still build atreides ones from HFac. But that's just my idea.

Member

MustaphaTR commented Feb 16, 2017

We can't build combat tank from Starport.

Also i like the fact that Contrabants contain Ordos Tanks not Atreides. This wasn't the case in original even tho it was possible.

I feel like it would be better if Combat Tank we can buy from Smugglers was Ordos too, it is a Smugglers Starport. We can still build atreides ones from HFac. But that's just my idea.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Feb 16, 2017

Member

I feel like it would be better if Combat Tank we can buy from Smugglers was Ordos too, it is a Smugglers Starport. We can still build atreides ones from HFac. But that's just my idea.

Good idea. I added that.

I used DDDD00 for mercenaries and 542209 for smugglers in my older maps (and Ord4 for smugglers too).

Also thanks. I think they fit.

Member

abcdefg30 commented Feb 16, 2017

I feel like it would be better if Combat Tank we can buy from Smugglers was Ordos too, it is a Smugglers Starport. We can still build atreides ones from HFac. But that's just my idea.

Good idea. I added that.

I used DDDD00 for mercenaries and 542209 for smugglers in my older maps (and Ord4 for smugglers too).

Also thanks. I think they fit.

@penev92 penev92 referenced this pull request Feb 19, 2017

Open

Add Dune 2000 campaign #9287

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Feb 20, 2017

Member

Needs rebase.

Member

MustaphaTR commented Feb 20, 2017

Needs rebase.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Feb 20, 2017

Member

This walls and gun turret is lacking concrete below:
concrete

Member

MustaphaTR commented Feb 20, 2017

This walls and gun turret is lacking concrete below:
concrete

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Feb 20, 2017

Member

Rebased and updated.

Member

abcdefg30 commented Feb 20, 2017

Rebased and updated.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Feb 20, 2017

Member

AI in original mission do train infantry. I tested with Debug Menu in Gruntmods Edition. Looks like it is missing here. Don't forget to add upgrade.barracks too.

Member

MustaphaTR commented Feb 20, 2017

AI in original mission do train infantry. I tested with Debug Menu in Gruntmods Edition. Looks like it is missing here. Don't forget to add upgrade.barracks too.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Feb 20, 2017

Member

If i sell starport, Defend Starport mission doesn't fail.

Member

MustaphaTR commented Feb 20, 2017

If i sell starport, Defend Starport mission doesn't fail.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Feb 20, 2017

Member

Sardaukar is visible and buildable if you have hi-tech fac. after i capture Harkonnen Barracks/capture the CYard and build a Barracks.

Member

MustaphaTR commented Feb 20, 2017

Sardaukar is visible and buildable if you have hi-tech fac. after i capture Harkonnen Barracks/capture the CYard and build a Barracks.

@HenrytheSlav

This comment has been minimized.

Show comment
Hide comment
@HenrytheSlav

HenrytheSlav Mar 1, 2017

Contributor

Please add the .lua files to OpenRA.sln.

Contributor

HenrytheSlav commented Mar 1, 2017

Please add the .lua files to OpenRA.sln.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Mar 18, 2017

Contributor

#12784 was merged.

Contributor

reaperrr commented Mar 18, 2017

#12784 was merged.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Mar 18, 2017

Member

Rebased and updated.

Member

abcdefg30 commented Mar 18, 2017

Rebased and updated.

@MustaphaTR

👍

@ltem

ltem approved these changes Apr 4, 2017 edited

👍 Quite a challenge :)
One small nit...

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Apr 4, 2017

Member

Rebased and updated.

Member

abcdefg30 commented Apr 4, 2017

Rebased and updated.

@ltem

ltem approved these changes Apr 5, 2017

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Apr 12, 2017

Member

@reaperrr , can you take a look to this when you have time. It already have 2 approvals but waiting for merge for a while.

Member

MustaphaTR commented Apr 12, 2017

@reaperrr , can you take a look to this when you have time. It already have 2 approvals but waiting for merge for a while.

@reaperrr reaperrr merged commit 8e5fbfe into OpenRA:bleed Apr 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Apr 12, 2017

@abcdefg30 abcdefg30 deleted the abcdefg30:atreides05 branch Apr 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment