New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2K - Add Ordos Mission 2a #12880

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
4 participants
@MustaphaTR
Member

MustaphaTR commented Mar 3, 2017

This is the first map that needs #12809. For now as i said at there, i'm using OnEnteredFootprint.

Our reinforcements are moved to a transition tile, so it won't be blocked by buildings we build. It can be moved to original location when #12464 is fixed.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Mar 6, 2017

Contributor

I found some tile errors, I don't know if they are already fixed in #12784. I didn't see them because the map has in the gruntmod version a black padding and the OpenRA importer cannot cope with that.
I'll try to find an original map and test it.

Update 1: Wuhuu, the arrakis tile pr fixes all errors

Code & Gameplay: I didn't found any issues

Contributor

ltem commented Mar 6, 2017

I found some tile errors, I don't know if they are already fixed in #12784. I didn't see them because the map has in the gruntmod version a black padding and the OpenRA importer cannot cope with that.
I'll try to find an original map and test it.

Update 1: Wuhuu, the arrakis tile pr fixes all errors

Code & Gameplay: I didn't found any issues

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Mar 6, 2017

Member

I did the lazy way and just used existing similar tiles before that PR was out. I need to reimport the maps i guess.

Member

MustaphaTR commented Mar 6, 2017

I did the lazy way and just used existing similar tiles before that PR was out. I need to reimport the maps i guess.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Mar 6, 2017

Contributor

Yep but this is also needed for the other multiplayer maps so, it would happen either way

Contributor

ltem commented Mar 6, 2017

Yep but this is also needed for the other multiplayer maps so, it would happen either way

@ltem

One small question, everything else looks fine.

Show outdated Hide outdated mods/d2k/maps/ordos-02a/map.yaml
@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Mar 9, 2017

Member

Updated, but now depends on #12784.

Member

MustaphaTR commented Mar 9, 2017

Updated, but now depends on #12784.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Mar 18, 2017

Member

Rebased.

Member

MustaphaTR commented Mar 18, 2017

Rebased.

@ltem

ltem approved these changes Mar 21, 2017

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Mar 21, 2017

Contributor

👍

Contributor

ltem commented Mar 21, 2017

👍

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Mar 27, 2017

Contributor

@MustaphaTR The Harkonnen deploys to HarkonnenRally6 can be blocked by placing a building there. If this is fixable through lua please do, otherwise file an issue (unless there already is one) because in my opinion carryalls should automatically move to the closest free cell in such a situation.
Otherwise this mission plays fine, so 👍 once that is fixed or filed as issue.

Contributor

reaperrr commented Mar 27, 2017

@MustaphaTR The Harkonnen deploys to HarkonnenRally6 can be blocked by placing a building there. If this is fixable through lua please do, otherwise file an issue (unless there already is one) because in my opinion carryalls should automatically move to the closest free cell in such a situation.
Otherwise this mission plays fine, so 👍 once that is fixed or filed as issue.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Mar 27, 2017

Member

The Harkonnen deploys to HarkonnenRally6 can be blocked by placing a building there. If this is fixable through lua please do, otherwise because in my opinion carryalls should automatically move to the closest free cell in such a situation.

#12464

I can just change the location of the waypoint to an unbuildable cell for now tho.

Member

MustaphaTR commented Mar 27, 2017

The Harkonnen deploys to HarkonnenRally6 can be blocked by placing a building there. If this is fixable through lua please do, otherwise because in my opinion carryalls should automatically move to the closest free cell in such a situation.

#12464

I can just change the location of the waypoint to an unbuildable cell for now tho.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Mar 27, 2017

Member

Updated, moved that waypoint to a transition tile.

Member

MustaphaTR commented Mar 27, 2017

Updated, moved that waypoint to a transition tile.

@reaperrr reaperrr merged commit aa3f216 into OpenRA:bleed Mar 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Mar 29, 2017

@MustaphaTR MustaphaTR deleted the MustaphaTR:d2k-ordos-2a branch Mar 29, 2017

@penev92 penev92 referenced this pull request Mar 29, 2017

Open

Add Dune 2000 campaign #9287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment