New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contrail gets rendered between loading in and loading out position #12882

Merged
merged 1 commit into from Mar 19, 2017

Conversation

Projects
None yet
5 participants
@abc013
Contributor

abc013 commented Mar 3, 2017

Closes #12877.

Another option would be to create a new ContrailRenderable in AddedToWorld, right?

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Mar 3, 2017

Member

Another option would be to create a new ContrailRenderable in AddedToWorld, right?

Indeed, and this would be the better option.

Member

pchote commented Mar 3, 2017

Another option would be to create a new ContrailRenderable in AddedToWorld, right?

Indeed, and this would be the better option.

@abc013

This comment has been minimized.

Show comment
Hide comment
@abc013

abc013 Mar 5, 2017

Contributor

Updated.

Contributor

abc013 commented Mar 5, 2017

Updated.

@@ -54,7 +55,7 @@ public Contrail(Actor self, ContrailInfo info)
{
this.info = info;
var color = info.UsePlayerColor ? ContrailRenderable.ChooseColor(self) : info.Color;
color = info.UsePlayerColor ? ContrailRenderable.ChooseColor(self) : info.Color;
trail = new ContrailRenderable(self.World, color, info.TrailWidth, info.TrailLength, 0, info.ZOffset);

This comment has been minimized.

@abcdefg30

abcdefg30 Mar 6, 2017

Member

Hm, I think you could remove this now.

@abcdefg30

abcdefg30 Mar 6, 2017

Member

Hm, I think you could remove this now.

This comment has been minimized.

@abc013

abc013 Mar 8, 2017

Contributor

oh, updated it.

@abc013

abc013 Mar 8, 2017

Contributor

oh, updated it.

@GraionDilach

👍

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Mar 18, 2017

Contributor

When giving a Minigunner a Contrail, I got this:
https://gist.github.com/reaperrr/148110d46f831133f96614c23f40a6cd

Contributor

reaperrr commented Mar 18, 2017

When giving a Minigunner a Contrail, I got this:
https://gist.github.com/reaperrr/148110d46f831133f96614c23f40a6cd

@reaperrr

NRE needs fixing.

@abc013

This comment has been minimized.

Show comment
Hide comment
@abc013

abc013 Mar 19, 2017

Contributor

You got the error directly after the game started, right?

edit: a yeah, i got it too now.

Contributor

abc013 commented Mar 19, 2017

You got the error directly after the game started, right?

edit: a yeah, i got it too now.

@abc013

This comment has been minimized.

Show comment
Hide comment
@abc013

abc013 Mar 19, 2017

Contributor

Everything should work now.
The problem was that i removed this line.

Contributor

abc013 commented Mar 19, 2017

Everything should work now.
The problem was that i removed this line.

@abcdefg30 abcdefg30 merged commit d819f32 into OpenRA:bleed Mar 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Mar 19, 2017

@abc013 abc013 deleted the abc013:ContrailFix branch Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment