New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Captures Upgradeable #13010

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
6 participants
@MustaphaTR
Member

MustaphaTR commented Mar 22, 2017

Part 2 of #12604.

For test case i made D2K Engineer require Outpost to be able to capture.

Looks like the version i have was before #12862 merged, i think i applied it on my installment correctly (and it runs fine so it should be) but please be sure this doesn't revert anything from there.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Mar 24, 2017

Member

Updated.

Member

MustaphaTR commented Mar 24, 2017

Updated.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 17, 2017

Member

Rebased.

Member

MustaphaTR commented Jul 17, 2017

Rebased.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 23, 2017

Member

Updated.

Member

MustaphaTR commented Jul 23, 2017

Updated.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 23, 2017

Member

Updated.

Member

MustaphaTR commented Jul 23, 2017

Updated.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Aug 13, 2017

Member

Updated.

Member

MustaphaTR commented Aug 13, 2017

Updated.

@reaperrr

Looks good to me apart from minor nits

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Aug 17, 2017

Contributor

You can remove the test-case now, I think.

Contributor

reaperrr commented Aug 17, 2017

You can remove the test-case now, I think.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Aug 18, 2017

Member

Updated. Removed the testcase.

Member

MustaphaTR commented Aug 18, 2017

Updated. Removed the testcase.

@abcdefg30 abcdefg30 merged commit f798369 into OpenRA:bleed Aug 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Aug 21, 2017

@MustaphaTR MustaphaTR deleted the MustaphaTR:make-captures-upgradeable branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment