New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a windows version of the launch-game script. #13033

Merged
merged 1 commit into from Apr 1, 2017

Conversation

Projects
None yet
5 participants
@pchote
Member

pchote commented Mar 29, 2017

The windows counterpart to #12992.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Mar 29, 2017

Contributor

Is there a reason why this is placed in an OpenRA subfolder instead of the root folder like the other scripts?

Contributor

reaperrr commented Mar 29, 2017

Is there a reason why this is placed in an OpenRA subfolder instead of the root folder like the other scripts?

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Mar 29, 2017

Member

There was indeed a reason, but it was not intended to make it though to the PR. Fixed.

Member

pchote commented Mar 29, 2017

There was indeed a reason, but it was not intended to make it though to the PR. Fixed.

echo * Log Files are available in Documents\OpenRA\Logs
echo * FAQ is available at https://github.com/OpenRA/OpenRA/wiki/FAQ
echo ----------------------------------------
pause

This comment has been minimized.

@forcecore

forcecore Mar 29, 2017

Contributor

Nit: is it ok for .cmd not to have no EOL at end? (after pause)

@forcecore

forcecore Mar 29, 2017

Contributor

Nit: is it ok for .cmd not to have no EOL at end? (after pause)

@echo off
title OpenRA
:choosemod
set /P mod=Select mod (ra, cnc, d2k, ts) or --exit:

This comment has been minimized.

@Phrohdoh

Phrohdoh Mar 31, 2017

Member

Why would someone ever run launch-game.cmd --exit?

@Phrohdoh

Phrohdoh Mar 31, 2017

Member

Why would someone ever run launch-game.cmd --exit?

@echo off
title OpenRA
:choosemod
set /P mod=Select mod (ra, cnc, d2k, ts) or --exit:

This comment has been minimized.

@obrakmann

obrakmann Apr 1, 2017

Contributor

Same question as in #12992, really. How would this handle custom mods?

@obrakmann

obrakmann Apr 1, 2017

Contributor

Same question as in #12992, really. How would this handle custom mods?

This comment has been minimized.

@pchote

pchote Apr 1, 2017

Member

Same answer as #12992 here and below.

@pchote

pchote Apr 1, 2017

Member

Same answer as #12992 here and below.

if /I "%mod%" EQU "--exit" (exit)
if /I "%mod%" EQU "ra" (goto launch)
if /I "%mod%" EQU "cnc" (goto launch)
if /I "%mod%" EQU "ts" (goto launch)

This comment has been minimized.

@obrakmann

obrakmann Apr 1, 2017

Contributor

And again as in #12992, do we want to add that already?

@obrakmann

obrakmann Apr 1, 2017

Contributor

And again as in #12992, do we want to add that already?

@obrakmann

👍

@obrakmann obrakmann merged commit 832ae31 into OpenRA:bleed Apr 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann
Contributor

obrakmann commented Apr 1, 2017

@pchote pchote referenced this pull request Apr 1, 2017

Merged

Remove ingame mod chooser. #13049

@pchote pchote deleted the pchote:launch-game-dot-cmd branch May 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment