New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ingame mod chooser. #13049

Merged
merged 8 commits into from Apr 21, 2017

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented Apr 1, 2017

This implements the remaining engine changes to properly support stand-alone mod installs and removes the ability to install oramod packages to the support dir. All that remains for #12554 after this and the other PRs are merged are straightforward packaging changes to install mod-specific launch shortcuts on each platform.

Making Game.Mod a required argument means that players can no longer double click OpenRA.Game.exe in their file manager and expect the game to launch. They must instead use the launchers shipped in the installers, or for self-compiled versions either the MD/XS gui, the improved launch-game.sh, the new launch-game.cmd, or the launch scripts in the stand-alone mod template.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Apr 9, 2017

Member

Changed button labels to "Manage Content" and rebased.

Member

pchote commented Apr 9, 2017

Changed button labels to "Manage Content" and rebased.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Apr 14, 2017

Member

I've added a commit that fixes the deb packaging. It looks like our packaging scripts got out out sync across the last set of parallel PRs.

Member

pchote commented Apr 14, 2017

I've added a commit that fixes the deb packaging. It looks like our packaging scripts got out out sync across the last set of parallel PRs.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Apr 15, 2017

Member

Rebased after #12828.

Member

pchote commented Apr 15, 2017

Rebased after #12828.

@atlimit8

This comment has been minimized.

Show comment
Hide comment
@atlimit8

atlimit8 Apr 17, 2017

Member

Has this been tested by a reviewer in Windows?

Member

atlimit8 commented Apr 17, 2017

Has this been tested by a reviewer in Windows?

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Apr 17, 2017

Contributor

Has this been tested by a reviewer in Windows?

Yes (me).

Contributor

reaperrr commented Apr 17, 2017

Has this been tested by a reviewer in Windows?

Yes (me).

@pchote pchote removed the PR: Rebase me! label Apr 17, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Apr 17, 2017

Member

Has this been tested by a reviewer in Windows?

Yes (me).

I have also tested this on all three platforms as part of #13129, #13133, #13138.

Also, rebased after #13141.

Member

pchote commented Apr 17, 2017

Has this been tested by a reviewer in Windows?

Yes (me).

I have also tested this on all three platforms as part of #13129, #13133, #13138.

Also, rebased after #13141.

@obrakmann

Looks fine so far, just a couple of minor things. Package builds as well, and its contents look fine.

Show outdated Hide outdated OpenRA.Mods.Common/Widgets/Logic/ModBrowserLogic.cs
Show outdated Hide outdated OpenRA.Server/Program.cs
Show outdated Hide outdated OpenRA.Game/Game.cs
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Apr 21, 2017

Member

Ok. Changed.

Member

pchote commented Apr 21, 2017

Ok. Changed.

@obrakmann

👍

@obrakmann obrakmann merged commit 7f204b2 into OpenRA:bleed Apr 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann
Contributor

obrakmann commented Apr 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment