New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Offset property to SpawnActorOnDeath #13106

Merged
merged 1 commit into from Apr 20, 2017

Conversation

Projects
None yet
6 participants
@abcdefg30
Member

abcdefg30 commented Apr 11, 2017

As requested in #12980 (comment).

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Apr 11, 2017

Contributor

Shouldn't there be an edge-of-map check?

Contributor

GraionDilach commented Apr 11, 2017

Shouldn't there be an edge-of-map check?

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Apr 11, 2017

Member

We don't check on any other uses of LocationInit I'm aware of either.

Member

abcdefg30 commented Apr 11, 2017

We don't check on any other uses of LocationInit I'm aware of either.

@Phrohdoh

This comment has been minimized.

Show comment
Hide comment
@Phrohdoh

Phrohdoh Apr 11, 2017

Member

This would be a good place to start adding those checks.

Member

Phrohdoh commented Apr 11, 2017

This would be a good place to start adding those checks.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Apr 17, 2017

Member

Adding checks to block spawning opens a huge can of worms. What happens if an important unit feature requires this to work, but it is blocked?

My preference for a simple solution is to add a warning to the [Desc()] explaining undefined behaviour if the spawned unit extends outside the footprint/influence of the spawner.

The LaysTerrain testcase should already work correctly if it spawns partially outside the map.

Member

pchote commented Apr 17, 2017

Adding checks to block spawning opens a huge can of worms. What happens if an important unit feature requires this to work, but it is blocked?

My preference for a simple solution is to add a warning to the [Desc()] explaining undefined behaviour if the spawned unit extends outside the footprint/influence of the spawner.

The LaysTerrain testcase should already work correctly if it spawns partially outside the map.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Apr 17, 2017

Contributor

Valid points, I'm fine with the description update.

Contributor

GraionDilach commented Apr 17, 2017

Valid points, I'm fine with the description update.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Apr 18, 2017

Member

Added the warning.

Member

abcdefg30 commented Apr 18, 2017

Added the warning.

@GraionDilach

👍

@reaperrr reaperrr merged commit ebb6505 into OpenRA:bleed Apr 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Apr 20, 2017

@abcdefg30 abcdefg30 deleted the abcdefg30:spawnOffset branch Apr 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment