New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using launch-game.cmd with parameters #13116

Merged
merged 2 commits into from May 20, 2017

Conversation

Projects
None yet
3 participants
@abcdefg30
Member

abcdefg30 commented Apr 13, 2017

Follow-up of #13033.
You can now specify the mod when calling launch-game.cmd from the command line.

@pchote

I'd prefer it if we could make this work the same way as launch-game.sh: pass all the arguments to OpenRA.Game.exe, and show the chooser if one of them doesn't start with Game.Mod=.

This link might be helpful: http://stackoverflow.com/questions/29655065/check-if-batch-variable-starts-with

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 May 11, 2017

Member

Updated.

Member

abcdefg30 commented May 11, 2017

Updated.

@abcdefg30 abcdefg30 dismissed stale reviews from reaperrr and pchote May 11, 2017

Code was changed

@pchote

pchote approved these changes May 13, 2017

@pchote pchote added the PR: Needs +2 label May 13, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr May 19, 2017

Contributor

The console window still closes for me when closing the game.
First commit works, though.

Contributor

reaperrr commented May 19, 2017

The console window still closes for me when closing the game.
First commit works, though.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 May 19, 2017

Member

If you open it by double clicking, it should still close. The window just remains open now, if you used the command line to execute the script.

Member

abcdefg30 commented May 19, 2017

If you open it by double clicking, it should still close. The window just remains open now, if you used the command line to execute the script.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr May 20, 2017

Contributor

Right, my bad. 👍 then.

Contributor

reaperrr commented May 20, 2017

Right, my bad. 👍 then.

@reaperrr reaperrr merged commit ac4fef6 into OpenRA:bleed May 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:launch branch May 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment