Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
LAN games discovery #8906 #13132
This PR fails continuous integration tests. I don't think it will compile for others. Try making a clean clone of your branch in a different location and building that.
The overall approach looks good, just a couple of suggestions/requests to make the logic simpler and more maintainable.
This works really well, good job! I have a few more requests below, but then I think this should be good to merge. We should also get
I notice a few "System.Net.Sockets.SocketOptionName 0x17 is not supported at IP level" being written to stdout by, i assume, beaconlib, but that doesn't appear to stop it from working.
Finally, it would be nice for polish if we could change the "Country" column in the server browser to "Location", and then have local games show as "Local Network" instead of "Unknown Loca...".
The easiest way will be to check if the server IP matches the reserved internal IP ranges, but in any case this is out of scope for this PR and should be left to a followup.
Updated as requested but with some additional changes to be reviewed.