New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows packaging for per-mod launchers. #13133

Merged
merged 4 commits into from Apr 26, 2017

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented Apr 15, 2017

This updates the windows packaging to install separate launchers and shortcuts for each mod, as well as some other much needed changes:

  • Release/playtest/dev installs are treated separately and can now be installed side by side.
  • Removed the readme and uninstaller links from the start menu to conform with best practices.
  • Includes additional metadata (version, install size, readme, quiet uninstall command) for the control panel software list.

Depends on #13049.

Test build (fake playtest): OpenRA-playtest-20170415.exe.
Test build (dev version): See Appveyor artefact page.
The two test builds can be installed together to test the side-by-side version support.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Apr 21, 2017

Member

Rebased after #13049.

Member

pchote commented Apr 21, 2017

Rebased after #13049.

@Phrohdoh

Phrohdoh approved these changes Apr 25, 2017 edited

LGTM

pinging @abcdefg30 and/or @reaperrr

@pchote pchote added the PR: Needs +2 label Apr 25, 2017

@pchote pchote requested review from reaperrr and abcdefg30 Apr 25, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Apr 25, 2017

Contributor

I'm too tired to review this now, I'll do so tomorrow unless someone beats me to it.

Contributor

reaperrr commented Apr 25, 2017

I'm too tired to review this now, I'll do so tomorrow unless someone beats me to it.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Apr 26, 2017

Contributor

All launchers work, side-by-side installs work, installation and deinstallation (from system control) works.

My question on that duplication aside, I consider this mergable.

Contributor

reaperrr commented Apr 26, 2017

All launchers work, side-by-side installs work, installation and deinstallation (from system control) works.

My question on that duplication aside, I consider this mergable.

Improve general installer quality:
- Remove uninstaller and readme start menu links
  (they are explicitly discouraged by best practices)
- Explicitly declare installer execution level
- Define additional control panel metadata

@pchote pchote merged commit 60bc114 into OpenRA:bleed Apr 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:windows-packaging branch May 7, 2017

@reaperrr reaperrr modified the milestones: Next Release, Next + 1 Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment