New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require cancelled move orders to exit tunnels before completion. #13149

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Apr 17, 2017

This is my take on the rejecting orders in tunnels issue discussed in #12924. This extends the "unit must finish moving into the next cell before it can start on the next activity" logic from normal movement cancellation to also apply to tunnels.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Apr 17, 2017

Member

It may be helpful to view this suppressing whitespace changes: https://github.com/OpenRA/OpenRA/pull/13149/files?w=1

Member

pchote commented Apr 17, 2017

It may be helpful to view this suppressing whitespace changes: https://github.com/OpenRA/OpenRA/pull/13149/files?w=1

@obrakmann

lgtm, 👍

@reaperrr reaperrr merged commit afc1f22 into OpenRA:bleed Apr 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Apr 18, 2017

@pchote pchote referenced this pull request Apr 21, 2017

Closed

General tunnel issues #12662

2 of 3 tasks complete

@pchote pchote deleted the pchote:defer-tunnel-orders branch May 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment