New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helis return to nearest base like Planes #13178

Merged
merged 1 commit into from May 7, 2017

Conversation

Projects
None yet
3 participants
@rob-v
Contributor

rob-v commented Apr 22, 2017

Heli unification of behaviour with Plane

Closes #13173

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Apr 30, 2017

Member

The reactions we had to deal with from parts of the player community the last time we fixed issues with the aircraft RTB behaviour really puts me off wanting to deal with this part of the code again.

Could somebody please check through the discussions linked from the release-20161015 changelog and make sure that this isn't breaking somebodies pet edge case?

Member

pchote commented Apr 30, 2017

The reactions we had to deal with from parts of the player community the last time we fixed issues with the aircraft RTB behaviour really puts me off wanting to deal with this part of the code again.

Could somebody please check through the discussions linked from the release-20161015 changelog and make sure that this isn't breaking somebodies pet edge case?

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v Apr 30, 2017

Contributor

An idea - instead of returning to nearest/oldest base, helis and planes return to primary base

Contributor

rob-v commented Apr 30, 2017

An idea - instead of returning to nearest/oldest base, helis and planes return to primary base

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v Apr 30, 2017

Contributor

Looking briefly at all those requests and issues I understand why you are worried. In this case I think this is wanted and safe feature - you can compare ReturnToBase.ChooseAirfield with HeliReturnToBase.ChooseHelipad - the behaviour is unified and requested.

Contributor

rob-v commented Apr 30, 2017

Looking briefly at all those requests and issues I understand why you are worried. In this case I think this is wanted and safe feature - you can compare ReturnToBase.ChooseAirfield with HeliReturnToBase.ChooseHelipad - the behaviour is unified and requested.

@pchote

pchote approved these changes May 6, 2017

@pchote pchote added the PR: Needs +2 label May 6, 2017

@reaperrr reaperrr merged commit 74437ed into OpenRA:bleed May 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rob-v rob-v deleted the rob-v:ReturnHeliToNearestBase branch May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment