New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "game" chat tab mouseover not working from globalchat login tab. #13185

Merged
merged 2 commits into from May 27, 2017

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented Apr 23, 2017

Fixes #10415.
Fixes #13277.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote May 7, 2017

Member

Rebased.

Member

pchote commented May 7, 2017

Rebased.

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v May 10, 2017

Contributor

It was missed in another PR, but there should be spaces added in 2 lobby_globalchat.yaml files: Width: PARENT_RIGHT-27 + in 2 files not changed by this PR: multiplayer_globalchat.yaml.

Contributor

rob-v commented May 10, 2017

It was missed in another PR, but there should be spaces added in 2 lobby_globalchat.yaml files: Width: PARENT_RIGHT-27 + in 2 files not changed by this PR: multiplayer_globalchat.yaml.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote May 25, 2017

Member

Updated. This now also fixes #13277.

Member

pchote commented May 25, 2017

Updated. This now also fixes #13277.

@rob-v

rob-v approved these changes May 25, 2017

@abcdefg30

This also fixes the crash when using ]games.

@abcdefg30 abcdefg30 merged commit 7f3f368 into OpenRA:bleed May 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented May 27, 2017

@pchote pchote deleted the pchote:fix-lobby-chat-tab-mouseover branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment