New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Selecting a map resets player color #13201

Merged
merged 1 commit into from May 14, 2017

Conversation

Projects
None yet
3 participants
@rob-v
Contributor

rob-v commented Apr 27, 2017

Closes #11898.

@@ -306,7 +306,7 @@ void ValidateClient(Connection newConn, string data)
IpAddress = ((IPEndPoint)newConn.Socket.RemoteEndPoint).Address.ToString(),
Index = newConn.PlayerIndex,
Slot = LobbyInfo.FirstEmptySlot(),
PreferredColor = handshake.Client.Color,
PreferredColor = handshake.Client.PreferredColor,

This comment has been minimized.

@pchote

pchote Apr 30, 2017

Member

I remember having a specific reason for using Color here, but I can't remember what it was. Probably working around some even older bug that is no longer valid.

@pchote

pchote Apr 30, 2017

Member

I remember having a specific reason for using Color here, but I can't remember what it was. Probably working around some even older bug that is no longer valid.

@pchote pchote dismissed their stale review Apr 30, 2017

Changes made.

@pchote

pchote approved these changes May 14, 2017

👍 with that minor fix.

Note that a much more obvious effect of this bug, which is what we should mention in the changelog for this, is that the server will reset your color when you change slots.

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v May 14, 2017

Contributor

Updated.

Contributor

rob-v commented May 14, 2017

Updated.

@pchote pchote merged commit b2e6a04 into OpenRA:bleed May 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rob-v rob-v deleted the rob-v:SelectMapResetsPlayerColor branch May 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment