New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RangeMultiplier regression. #13219

Merged
merged 1 commit into from May 5, 2017

Conversation

Projects
None yet
3 participants
@GraionDilach
Contributor

GraionDilach commented May 1, 2017

The Default suffix was incosistent with the others and wasn't applied everywhere - case in point https://github.com/OpenRA/OpenRA/blob/bleed/OpenRA.Mods.Common/Traits/Armament.cs#L149 - which made it broken.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach May 1, 2017

Contributor

Oh damn, I've misread this.

Contributor

GraionDilach commented May 1, 2017

Oh damn, I've misread this.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach May 1, 2017

Contributor

Now fixed properly.

Contributor

GraionDilach commented May 1, 2017

Now fixed properly.

@atlimit8 atlimit8 merged commit 4ec0089 into OpenRA:bleed May 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@atlimit8

This comment has been minimized.

Show comment
Hide comment
@atlimit8
Member

atlimit8 commented May 5, 2017

@GraionDilach GraionDilach deleted the GraionDilach:fix-rangemodifier-regression branch May 5, 2017

@GraionDilach GraionDilach referenced this pull request May 11, 2017

Closed

Ship a bugfix release #13274

17 of 17 tasks complete

@GraionDilach GraionDilach referenced this pull request Jul 6, 2017

Closed

RangeMultiplier #13598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment