New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TD Supply Truck #13231

Merged
merged 1 commit into from Jul 16, 2017

Conversation

Projects
None yet
7 participants
@anjew175
Contributor

anjew175 commented May 3, 2017

Adds supply truck to TD
closes #12849

@pchote

Adding the supply truck fills a known gameplay hole, so the premise of this PR is fine with me.

However, in addition to the issues raised by @GraionDilach and @MustaphaTR I have two more:

  • This is a low tech unit, so the build icon should be in the top row of the palette (low BuildPaletteOrder).
  • The palette didn't convert very well, the artwork looks glitchy ingame:
    screen shot 2017-05-06 at 10 10 10 screen shot 2017-05-06 at 10 09 59
@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach May 6, 2017

Contributor

Is this the RA1 Truck? If yes, maybe it would make more sense using the original artwork with the RA pal instead of converting the artwork to TD.

Contributor

GraionDilach commented May 6, 2017

Is this the RA1 Truck? If yes, maybe it would make more sense using the original artwork with the RA pal instead of converting the artwork to TD.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote May 6, 2017

Member

I don't want to have to pull in the RA palette (yet another non-free binary file in our repo) and bloat the palette definitions just for one unit.

Member

pchote commented May 6, 2017

I don't want to have to pull in the RA palette (yet another non-free binary file in our repo) and bloat the palette definitions just for one unit.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach May 6, 2017

Contributor

Converting palette between TD and RA requires 2-pass methods (!) which I presume is above @anjew175 's level (yes, that's required simply because of the different position of the remap gradient). And I have noidea how the result will look like.

Contributor

GraionDilach commented May 6, 2017

Converting palette between TD and RA requires 2-pass methods (!) which I presume is above @anjew175 's level (yes, that's required simply because of the different position of the remap gradient). And I have noidea how the result will look like.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR May 7, 2017

Member

I converted it with XCC Mixer easily. Here is the file: http://www.mediafire.com/file/ii0z2uwqsmmcb93/tdtruk.shp

truks

Member

MustaphaTR commented May 7, 2017

I converted it with XCC Mixer easily. Here is the file: http://www.mediafire.com/file/ii0z2uwqsmmcb93/tdtruk.shp

truks

@anjew175

This comment has been minimized.

Show comment
Hide comment
@anjew175

anjew175 May 22, 2017

Contributor

Has been updated to adhere to requested changes

Contributor

anjew175 commented May 22, 2017

Has been updated to adhere to requested changes

@pchote pchote dismissed their stale review May 22, 2017

PR updated.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Jul 12, 2017

Contributor

The code looks fine (Note: it won't spawn a moneycrate on death) but the artwork looks still glitchy on the desert terrain.

screens

Contributor

ltem commented Jul 12, 2017

The code looks fine (Note: it won't spawn a moneycrate on death) but the artwork looks still glitchy on the desert terrain.

screens

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 15, 2017

Contributor

Rebased and updated the sprite to work on all terrain:
truk-tem
truk-des

Contributor

reaperrr commented Jul 15, 2017

Rebased and updated the sprite to work on all terrain:
truk-tem
truk-des

@abcdefg30 abcdefg30 added this to the Next release milestone Jul 15, 2017

@GraionDilach

👍 then.

@ltem

ltem approved these changes Jul 16, 2017

Looks good.

@pchote

pchote approved these changes Jul 16, 2017

@pchote pchote merged commit ce671a2 into OpenRA:bleed Jul 16, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@anjew175

This comment has been minimized.

Show comment
Hide comment
@anjew175

anjew175 Jul 16, 2017

Contributor

Thank you for doing up the sprites @reaperrr
Look great.

I had no idea sprites could look good on one terrain and shit on another

Contributor

anjew175 commented Jul 16, 2017

Thank you for doing up the sprites @reaperrr
Look great.

I had no idea sprites could look good on one terrain and shit on another

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 16, 2017

Contributor

I had no idea sprites could look good on one terrain and shit on another

Unlike RA, TD currently uses the terrain-specific palettes for units and buildings, too. That's fine for TD sprites because Westwood designed the sprites to not use tileset-specific colors, but when converting unit shps from RA to TD or vice-versa using the normal palettes, XCC Mixer simply uses the closest match it can find, or first perfect match, and quite often that's a terrain color index. I have some custom modified palettes here where these tileset colors are replaced with pink, so XCC Mixer won't use those indexes when converting to shp.

Contributor

reaperrr commented Jul 16, 2017

I had no idea sprites could look good on one terrain and shit on another

Unlike RA, TD currently uses the terrain-specific palettes for units and buildings, too. That's fine for TD sprites because Westwood designed the sprites to not use tileset-specific colors, but when converting unit shps from RA to TD or vice-versa using the normal palettes, XCC Mixer simply uses the closest match it can find, or first perfect match, and quite often that's a terrain color index. I have some custom modified palettes here where these tileset colors are replaced with pink, so XCC Mixer won't use those indexes when converting to shp.

@reaperrr reaperrr modified the milestones: Next Release, Next + 1 Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment