New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit stance hotkeys #13263

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
5 participants
@rob-v
Contributor

rob-v commented May 9, 2017

Add hotkeys for Unit stances. 'Cycle stances' is kept atm and default for new hotkeys is Unknown, so no impact for players. IMO 'Cycle stances' could be removed.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach May 9, 2017

Contributor

This would be really cool if it would also add a decorational trait to showcase the current stance of the unit, especially considering these new buttons doesn't have any visible feedback on their effect as-is.

Contributor

GraionDilach commented May 9, 2017

This would be really cool if it would also add a decorational trait to showcase the current stance of the unit, especially considering these new buttons doesn't have any visible feedback on their effect as-is.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote May 9, 2017

Member

#3437, but that's out of scope for this PR.

I agree that we need some kind of feedback, but a message to the chat would be good enough for now.

Member

pchote commented May 9, 2017

#3437, but that's out of scope for this PR.

I agree that we need some kind of feedback, but a message to the chat would be good enough for now.

@atlimit8

This comment has been minimized.

Show comment
Hide comment
@atlimit8

atlimit8 May 24, 2017

Member

I would like to close #3437 before merging this.

Member

atlimit8 commented May 24, 2017

I would like to close #3437 before merging this.

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v May 26, 2017

Contributor

Updated - new Unit stance commands section, hotkey defaults Alt+..

Contributor

rob-v commented May 26, 2017

Updated - new Unit stance commands section, hotkey defaults Alt+..

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote May 29, 2017

Member

IMO 'Cycle stances' could be removed.

I agree. Let's do it.

Member

pchote commented May 29, 2017

IMO 'Cycle stances' could be removed.

I agree. Let's do it.

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v May 29, 2017

Contributor

Updated - removed Cycle Stance hotkey + fixed rare issue when first selected actor didn't have EnableStances on, then stance was not changed for remaining selected actors.

Contributor

rob-v commented May 29, 2017

Updated - removed Cycle Stance hotkey + fixed rare issue when first selected actor didn't have EnableStances on, then stance was not changed for remaining selected actors.

@pchote

pchote approved these changes May 29, 2017

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v May 29, 2017

Contributor

Updated - removed actor check in SetUnitStance (PerformStanceCycle)

Contributor

rob-v commented May 29, 2017

Updated - removed actor check in SetUnitStance (PerformStanceCycle)

@obrakmann

lgtm, 👍

@obrakmann obrakmann merged commit ada5b6d into OpenRA:bleed May 30, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann
Contributor

obrakmann commented May 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment